[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CACRpkdZ+TRb9OFTMHFCW6FYP10hNJFbuods04XK8=zq4bC8cHg@mail.gmail.com>
Date: Wed, 28 Aug 2013 15:48:39 +0200
From: Linus Walleij <linus.walleij@...aro.org>
To: Boris BREZILLON <b.brezillon@...rkiz.com>
Cc: Rob Herring <rob.herring@...xeda.com>,
Pawel Moll <pawel.moll@....com>,
Mark Rutland <mark.rutland@....com>,
Stephen Warren <swarren@...dotorg.org>,
Ian Campbell <ian.campbell@...rix.com>,
Rob Landley <rob@...dley.net>,
Jean-Christophe PLAGNIOL-VILLARD <plagnioj@...osoft.com>,
Nicolas Ferre <nicolas.ferre@...el.com>,
Richard Genoud <richard.genoud@...il.com>,
Jiri Kosina <jkosina@...e.cz>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] pinctrl: at91: add support for OUTPUT config
On Wed, Aug 28, 2013 at 3:46 PM, Linus Walleij <linus.walleij@...aro.org> wrote:
> On Tue, Aug 27, 2013 at 4:51 PM, Boris BREZILLON
> <b.brezillon@...rkiz.com> wrote:
>
>> Add support for pin output control through the pinctrl config:
>> - support enabling/disabling output on a given pin
>> - support output level setting (high or low)
>>
>> Signed-off-by: Boris BREZILLON <b.brezillon@...rkiz.com>
>
> NAK.
>
> We already have this:
>
> * @PIN_CONFIG_OUTPUT: this will configure the pin in output, use argument
> * 1 to indicate high level, argument 0 to indicate low level.
>
> It also has device tree bindings:
>
> output-low - set the pin to output mode with low level
> output-high - set the pin to output mode with high level
Bah maybe I'm misunderstanding :-(
So this is not part of the generic pin config series, but something
stand-alone to augment the existing driver to do this?
So I just apply this patch right off then?
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists