linux-kernel - Re: [PATCH 33/35] power: use dev_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <002d01cea395$0ef33ec0$2cd9bc40$%han@samsung.com>
Date:	Wed, 28 Aug 2013 11:19:43 +0900
From:	Jingoo Han <jg1.han@...sung.com>
To:	'Anton Vorontsov' <anton@...msg.org>
Cc:	'David Woodhouse' <dwmw2@...radead.org>,
	linux-kernel@...r.kernel.org,
	'Dan Carpenter' <dan.carpenter@...cle.com>,
	'Joe Perches' <joe@...ches.com>,
	'Greg Kroah-Hartman' <gregkh@...uxfoundation.org>,
	'Andrew Morton' <akpm@...ux-foundation.org>,
	'Mark Brown' <broonie@...nel.org>,
	'Jingoo Han' <jg1.han@...sung.com>
Subject: Re: [PATCH 33/35] power: use dev_get_platdata()

On Wednesday, August 28, 2013 10:59 AM, Anton Vorontsov wrote:
> On Tue, Aug 13, 2013 at 12:00:39PM +0300, Dan Carpenter wrote:
> > > > > Use the wrapper function for retrieving the platform data instead of
> > > > > accessing dev->platform_data directly.
> > > >
> > > > Um.. what is the benefit or rationale of this patch?
> > >
> > > CC'ed Joe Perches, Dan Carpenter
> > >
> > > Hi Anton Vorontsov,
> > >
> > > Usually, using the wrapper function makes the code simpler.
> > > Also, it make the code more readable.
> >
> > Since people are asking my opinion, then yes using
> > dev_get_platdata() as intended is better than open coding.  It's a
> > coding standard thing.
> 
> I don't see any immediate benefit of applying this patch... It does not
> fix anything now or in the near future (or we are about to add something
> into dev_get_platdata() wrapper, or get rid of dev.platform_data member?
> Any plans for this? Then it should be in the commit message.)

CC'ed Greg Kroah-Hartman, Andrew Morton, Mark Brown

The benefit is that this wrapper function makes the code simpler and
enhances readability. I don't know why you disagree. :(
Also, this is a cosmetic change which does not have harmful effect.

There is no special plan.
I just want to make the best use of this wrapper function in order to
enhance readability and make the code simpler.

> 
> Without any plans to actually use the wrapper the patch is just a churn
> [that might result into patch conflicts that I'll have to deal with], so
> I'll refrain from applying it.

Um, if you want, I will send v2 patch re-based on the latest git tree.
Please, consider this patch positively. :-)
Thank you.

Best regards,
Jingoo Han


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/