linux-kernel - Re: Missing removal of sysfs attributes in gpiolib

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 28 Aug 2013 11:31:39 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Guenter Roeck <linux@...ck-us.net>
Cc:	linux-kernel@...r.kernel.org,
	Grant Likely <grant.likely@...aro.org>,
	Linus Walleij <linus.walleij@...aro.org>
Subject: Re: Missing removal of sysfs attributes in gpiolib

On Wed, Aug 28, 2013 at 10:57:17AM -0700, Guenter Roeck wrote:
> Hi,
> 
> I noticed that gpiolib does not explicitly remove the sysfs attributes it
> created when exporting a gpio pin when the pin is unexported, ie when the
> associated device is removed.
> 
> Are those attributes auto-removed when device_unregister() is called ?

Yes they are.

> Sorry if this is a dumb question - I have not noticed this anywhere else,
> and I don't seem to be able to find the code actually performing auto-removal
> of manually created attributes, so I wonder if this is a bug or intentional.

Hm, I thought this was listed in the kobject.txt documentation file, but
I don't seem to find it there.

But, ideally you aren't creating individual attributes directly, you are
using attribute groups for the device, right?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/