linux-kernel - Re: [PATCH 13/13] tracing/uprobes: Add support for full argument access methods

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87d2oyv0cr.fsf@sejong.aot.lge.com>
Date:	Wed, 28 Aug 2013 14:41:08 +0900
From:	Namhyung Kim <namhyung@...nel.org>
To:	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>
Cc:	Steven Rostedt <rostedt@...dmis.org>,
	Namhyung Kim <namhyung.kim@....com>,
	Hyeoncheol Lee <cheol.lee@....com>,
	LKML <linux-kernel@...r.kernel.org>,
	Srikar Dronamraju <srikar@...ux.vnet.ibm.com>,
	Oleg Nesterov <oleg@...hat.com>,
	"zhangwei\(Jovi\)" <jovi.zhangwei@...wei.com>,
	Arnaldo Carvalho de Melo <acme@...stprotocols.net>
Subject: Re: [PATCH 13/13] tracing/uprobes: Add support for full argument access methods

On Tue, 27 Aug 2013 20:54:45 +0900, Masami Hiramatsu wrote:
> (2013/08/27 17:48), Namhyung Kim wrote:
>> @@ -315,13 +316,18 @@ static int parse_probe_vars(char *arg, const struct fetch_type *t,
>>  			ret = -EINVAL;
>>  	} else if (strncmp(arg, "stack", 5) == 0) {
>>  		if (arg[5] == '\0') {
>> -			if (strcmp(t->name, DEFAULT_FETCH_TYPE_STR) == 0)
>> -				f->fn = fetch_stack_address;
>> -			else
>> -				ret = -EINVAL;
>> +			if (strcmp(t->name, DEFAULT_FETCH_TYPE_STR))
>> +				return -EINVAL;
>> +
>> +			if (is_kprobe)
>> +				f->fn = fetch_kernel_stack_address;
>> +			else {
>> +				f->fn = t->fetch[FETCH_MTD_stack];
>> +				f->data = (void *)0;
>> +			}
>
> No, the 'stack' means the address of the stack frame. Perhaps you might make a
> new function to retrieve it from pt_regs.

Hmm.. right.  How about this?


static __kprobes void fetch_user_stack_address(struct pt_regs *regs,
					  void *dummy, void *dest, void *priv)
{
	*(unsigned long *)dest = user_stack_pointer(regs);
}


...

			if (is_kprobe)
				f->fn = fetch_kernel_stack_address;
			else
				f->fn = fetch_user_stack_address;


Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/