linux-kernel - Re: [PATCH 01/12] KVM: MMU: remove unused parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130829072259.GZ22899@redhat.com>
Date:	Thu, 29 Aug 2013 10:22:59 +0300
From:	Gleb Natapov <gleb@...hat.com>
To:	Xiao Guangrong <xiaoguangrong@...ux.vnet.ibm.com>
Cc:	avi.kivity@...il.com, mtosatti@...hat.com, pbonzini@...hat.com,
	linux-kernel@...r.kernel.org, kvm@...r.kernel.org
Subject: Re: [PATCH 01/12] KVM: MMU: remove unused parameter

On Tue, Jul 30, 2013 at 09:01:59PM +0800, Xiao Guangrong wrote:
> ＠vcpu in page_fault_can_be_fast() is not used so remove it
> 
> Signed-off-by: Xiao Guangrong <xiaoguangrong@...ux.vnet.ibm.com>
Applied this one. Thanks.

> ---
>  arch/x86/kvm/mmu.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c
> index 3a9493a..a731c0b 100644
> --- a/arch/x86/kvm/mmu.c
> +++ b/arch/x86/kvm/mmu.c
> @@ -2808,7 +2808,7 @@ exit:
>  	return ret;
>  }
>  
> -static bool page_fault_can_be_fast(struct kvm_vcpu *vcpu, u32 error_code)
> +static bool page_fault_can_be_fast(u32 error_code)
>  {
>  	/*
>  	 * Do not fix the mmio spte with invalid generation number which
> @@ -2861,7 +2861,7 @@ static bool fast_page_fault(struct kvm_vcpu *vcpu, gva_t gva, int level,
>  	bool ret = false;
>  	u64 spte = 0ull;
>  
> -	if (!page_fault_can_be_fast(vcpu, error_code))
> +	if (!page_fault_can_be_fast(error_code))
>  		return false;
>  
>  	walk_shadow_page_lockless_begin(vcpu);
> -- 
> 1.8.1.4

--
			Gleb.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/