linux-kernel - Re: [PATCH 04/16] cpufreq: cpu0: use cpufreq_generic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 29 Aug 2013 21:07:27 +0800
From:	Shawn Guo <shawn.guo@...aro.org>
To:	Viresh Kumar <viresh.kumar@...aro.org>
CC:	<rjw@...k.pl>, <linaro-kernel@...ts.linaro.org>,
	<patches@...aro.org>, <cpufreq@...r.kernel.org>,
	<linux-pm@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 04/16] cpufreq: cpu0: use cpufreq_generic_get() routine

On Fri, Aug 23, 2013 at 09:20:39PM +0530, Viresh Kumar wrote:
> We have common infrastructure available with us for getting a CPUs clk rate.
> Lets use it for this driver.
> 
> Cc: Shawn Guo <shawn.guo@...aro.org>

Both this and imx6q one,

Acked-by: Shawn Guo <shawn.guo@...aro.org>

> Signed-off-by: Viresh Kumar <viresh.kumar@...aro.org>
> ---
>  drivers/cpufreq/cpufreq-cpu0.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/cpufreq/cpufreq-cpu0.c b/drivers/cpufreq/cpufreq-cpu0.c
> index 7273bfc..62e52e3 100644
> --- a/drivers/cpufreq/cpufreq-cpu0.c
> +++ b/drivers/cpufreq/cpufreq-cpu0.c
> @@ -29,11 +29,6 @@ static struct clk *cpu_clk;
>  static struct regulator *cpu_reg;
>  static struct cpufreq_frequency_table *freq_table;
>  
> -static unsigned int cpu0_get_speed(unsigned int cpu)
> -{
> -	return clk_get_rate(cpu_clk) / 1000;
> -}
> -
>  static int cpu0_set_target(struct cpufreq_policy *policy, unsigned int index)
>  {
>  	struct opp *opp;
> @@ -99,6 +94,7 @@ static int cpu0_set_target(struct cpufreq_policy *policy, unsigned int index)
>  
>  static int cpu0_cpufreq_init(struct cpufreq_policy *policy)
>  {
> +	policy->clk = cpu_clk;
>  	return cpufreq_generic_init(policy, freq_table, transition_latency);
>  }
>  
> @@ -106,7 +102,7 @@ static struct cpufreq_driver cpu0_cpufreq_driver = {
>  	.flags = CPUFREQ_STICKY,
>  	.verify = cpufreq_generic_frequency_table_verify,
>  	.target_index = cpu0_set_target,
> -	.get = cpu0_get_speed,
> +	.get = cpufreq_generic_get,
>  	.init = cpu0_cpufreq_init,
>  	.exit = cpufreq_generic_exit,
>  	.name = "generic_cpu0",
> -- 
> 1.7.12.rc2.18.g61b472e
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/