linux-kernel - Re: [PATCH v3] ARM: xen: only set pm function ptrs for Xen guests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1308291409470.6397@kaball.uk.xensource.com>
Date:	Thu, 29 Aug 2013 14:10:43 +0100
From:	Stefano Stabellini <stefano.stabellini@...citrix.com>
To:	Rob Herring <robherring2@...il.com>
CC:	<xen-devel@...ts.xensource.com>,
	<linux-arm-kernel@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>, <julien.grall@...aro.org>,
	Rob Herring <rob.herring@...xeda.com>,
	Stefano Stabellini <stefano.stabellini@...citrix.com>
Subject: Re: [PATCH v3] ARM: xen: only set pm function ptrs for Xen guests

On Thu, 29 Aug 2013, Rob Herring wrote:
> From: Rob Herring <rob.herring@...xeda.com>
> 
> xen_pm_init was unconditionally setting pm_power_off and arm_pm_restart
> function pointers. This breaks multi-platform kernels. Make this
> conditional on running as a Xen guest and make it a late_initcall to
> ensure it is setup after platform code for Dom0.
> 
> Cc: Stefano Stabellini <stefano.stabellini@...citrix.com>
> Signed-off-by: Rob Herring <rob.herring@...xeda.com>


Acked-by: Stefano Stabellini <stefano.stabellini@...citrix.com>

Added to my queue.


>  arch/arm/xen/enlighten.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c
> index 8a6295c..7071fca 100644
> --- a/arch/arm/xen/enlighten.c
> +++ b/arch/arm/xen/enlighten.c
> @@ -273,12 +273,15 @@ core_initcall(xen_guest_init);
>  
>  static int __init xen_pm_init(void)
>  {
> +	if (!xen_domain())
> +		return -ENODEV;
> +
>  	pm_power_off = xen_power_off;
>  	arm_pm_restart = xen_restart;
>  
>  	return 0;
>  }
> -subsys_initcall(xen_pm_init);
> +late_initcall(xen_pm_init);
>  
>  static irqreturn_t xen_arm_callback(int irq, void *arg)
>  {
> -- 
> 1.8.1.2
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/