linux-kernel - Re: [PATCH] [TRIVIAL] Remove braces in drivers/scsi/in2000.h to fix build for clang. No functional change otherwise.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4228569.UTsusHNv0I@aragorn.auenland.lan>
Date:	Thu, 29 Aug 2013 16:13:05 +0200
From:	Jan-Simon Möller <dl9pf@....de>
To:	Christoph Hellwig <hch@...radead.org>
Cc:	PaX Team <pageexec@...email.hu>,
	Behan Webster <behanw@...verseincode.com>,
	"James E.J. Bottomley" <JBottomley@...allels.com>,
	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [TRIVIAL] Remove braces in drivers/scsi/in2000.h to fix build for clang. No functional change otherwise.

Ping.
@Christoph  do you take care of removing then ? 

Or can we merge this patch as-is now.

Best,
JS


On Wednesday 21 August 2013 15:11:33 Jan-Simon Möller wrote:
> On Wednesday 21 August 2013 09:26:14 Jan-Simon Möller wrote:
> > > > Description:
> > > >   Clang chokes on the notation "insw (%%dx)" but works for "insw %%dx"
> > > >   (outsw likewise); GNU as accepts both forms.
> > > > 
> > > > Signed-off-by: Jan-Simon M??ller <dl9pf@....de>
> > > 
> > > I think the right fix is to simply kill the FAST_READ_IO/FAST_WRITE_IO
> > > defines and their associated inline assembly entirely.
> > 
> > No objection ;) .
> 
> @Christoph Hellwig:
> Do you take care of removing it then ?
> 
> BR,
> JS

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/