linux-kernel - Re: [PATCH] of/fdt: Remove duplicate memory clearing on FDT unflattening

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 29 Aug 2013 18:47:00 +0200
From:	Wladislav Wiebe <wladislav.kw@...il.com>
To:	Grant Likely <grant.likely@...aro.org>
CC:	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH] of/fdt: Remove duplicate memory clearing on FDT unflattening

On 29/08/13 15:44, Grant Likely wrote:
> Patch 9e4012752, "of: fdt: fix memory initialization for expanded DT"
> fixed incomplete clearing of memory when unflattening the device tree.
> However the code was already clearing some of the memory, it just wasn't
> doing so for all allocations. Now that the memory is cleared right at
> the point of allocation, the memset after unflatten_dt_alloc() is
> redundant. Remove it.

Acked-by: Wladislav Wiebe <wladislav.kw@...il.com>

> 
> Signed-off-by: Grant Likely <grant.likely@...aro.org>
> Cc: Wladislav Wiebe <wladislav.kw@...il.com>
> ---
>  drivers/of/fdt.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c
> index 55b028f..9d9be9617 100644
> --- a/drivers/of/fdt.c
> +++ b/drivers/of/fdt.c
> @@ -202,7 +202,6 @@ static void * unflatten_dt_node(struct boot_param_header *blob,
>  				__alignof__(struct device_node));
>  	if (allnextpp) {
>  		char *fn;
> -		memset(np, 0, sizeof(*np));
>  		np->full_name = fn = ((char *)np) + sizeof(*np);
>  		if (new_format) {
>  			/* rebuild full path for new format */
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/