linux-kernel - Re: [llvmlinux] [PATCH] [RFC] [X86] Fix a compilation issue with clang.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <521F8ED4.2080009@zytor.com>
Date:	Thu, 29 Aug 2013 11:11:32 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Jan-Simon Möller <dl9pf@....de>
CC:	llvmlinux@...ts.linuxfoundation.org, pageexec@...email.hu,
	x86@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [llvmlinux] [PATCH] [RFC] [X86] Fix a compilation issue with
 clang.

On 08/29/2013 11:00 AM, Jan-Simon Möller wrote:
>>
>> You just changed the sematics of the _ASM_* macros... that doesn't seem
>> like a great idea.  It's probably okay for the registers, but still...
> 
> Well, we followed your idea for the _ASM_DX macros as you mentioned them 
> earlier.
> 

We can probably do this, because register names are usually not assumed
to have spaces around them... so it's probably okay.  Definitely a lot
less ugly than the rest.  That being said, if we're going to fix these
macros, we should also fix another piece of drain bramage:

ALL instances of these have a % prepended.  The % should be part of the
macro.

	-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/