lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 29 Aug 2013 14:27:52 -0400 From: Alex Deucher <alexdeucher@...il.com> To: Meelis Roos <mroos@...ux.ee> Cc: Sergey Senozhatsky <sergey.senozhatsky@...il.com>, Alex Deucher <alexander.deucher@....com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Linux Kernel list <linux-kernel@...r.kernel.org>, Maling list - DRI developers <dri-devel@...ts.freedesktop.org> Subject: Re: [PATCH] radeon kms: fix uninitialised hotplug work usage in r100_irq_process() On Thu, Aug 29, 2013 at 6:55 AM, Meelis Roos <mroos@...ux.ee> wrote: >> Reported-by: Meelis Roos <mroos@...ux.ee> >> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@...il.com> > > It works, thank you for quick response! > > Tested-by: Meelis Roos <mroos@...ux.ee> Thanks. I've added it to my patch queue. Alex > >> drivers/gpu/drm/radeon/radeon_irq_kms.c | 10 ++++++---- >> 1 file changed, 6 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/gpu/drm/radeon/radeon_irq_kms.c b/drivers/gpu/drm/radeon/radeon_irq_kms.c >> index 081886b..cc9e848 100644 >> --- a/drivers/gpu/drm/radeon/radeon_irq_kms.c >> +++ b/drivers/gpu/drm/radeon/radeon_irq_kms.c >> @@ -275,17 +275,19 @@ int radeon_irq_kms_init(struct radeon_device *rdev) >> dev_info(rdev->dev, "radeon: using MSI.\n"); >> } >> } >> + >> + INIT_WORK(&rdev->hotplug_work, radeon_hotplug_work_func); >> + INIT_WORK(&rdev->audio_work, r600_audio_update_hdmi); >> + INIT_WORK(&rdev->reset_work, radeon_irq_reset_work_func); >> + >> rdev->irq.installed = true; >> r = drm_irq_install(rdev->ddev); >> if (r) { >> rdev->irq.installed = false; >> + flush_work(&rdev->hotplug_work); >> return r; >> } >> >> - INIT_WORK(&rdev->hotplug_work, radeon_hotplug_work_func); >> - INIT_WORK(&rdev->audio_work, r600_audio_update_hdmi); >> - INIT_WORK(&rdev->reset_work, radeon_irq_reset_work_func); >> - >> DRM_INFO("radeon: irq initialized.\n"); >> return 0; >> } >> > > -- > Meelis Roos (mroos@...ux.ee) > _______________________________________________ > dri-devel mailing list > dri-devel@...ts.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists