linux-kernel - Re: [PATCH 0/4] Unify CPU hotplug lock interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <21553065.6VHCMzStpF@vostro.rjw.lan>
Date:	Fri, 30 Aug 2013 02:06:09 +0200
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Toshi Kani <toshi.kani@...com>
Cc:	mingo@...hat.com, hpa@...ux.intel.com, tglx@...utronix.de,
	gregkh@...uxfoundation.org, benh@...nel.crashing.org,
	x86@...nel.org, linuxppc-dev@...ts.ozlabs.org,
	linux-kernel@...r.kernel.org, fenghua.yu@...el.com, bp@...e.de,
	srivatsa.bhat@...ux.vnet.ibm.com, isimatu.yasuaki@...fujitsu.com
Subject: Re: [PATCH 0/4] Unify CPU hotplug lock interface

On Thursday, August 29, 2013 11:15:10 AM Toshi Kani wrote:
> On Sun, 2013-08-18 at 03:02 +0200, Rafael J. Wysocki wrote:
> > On Saturday, August 17, 2013 01:46:55 PM Toshi Kani wrote:
> > > lock_device_hotplug() was recently introduced to serialize CPU & Memory
> > > online/offline and hotplug operations, along with sysfs online interface
> > > restructure (commit 4f3549d7).  With this new locking scheme,
> > > cpu_hotplug_driver_lock() is redundant and is no longer necessary.
> > > 
> > > This patchset makes sure that lock_device_hotplug() covers all CPU online/
> > > offline interfaces, and then removes cpu_hotplug_driver_lock().
> > > 
> > > The patchset is based on Linus's tree, 3.11.0-rc5.
> > 
> > Nice series, thanks a lot for taking care of this!
> 
> Hi Rafael,
> 
> Per the recent your changes in lock_device_hotplug(), do you think it
> makes sense to integrate this patchset into your tree?  I am also
> considering to add one more patch to use lock_device_hotplug_sysfs() in
> cpu_probe_store().  I will rebase to your tree and send them today if it
> makes sense to you.

Yes, it does to me.

Thanks,
Rafael


> > > ---
> > > Toshi Kani (4):
> > >   hotplug, x86: Fix online state in cpu0 debug interface
> > >   hotplug, x86: Add hotplug lock to missing places
> > >   hotplug, x86: Disable ARCH_CPU_PROBE_RELEASE on x86
> > >   hotplug, powerpc, x86: Remove cpu_hotplug_driver_lock()
> > > 
> > > ---
> > >  arch/powerpc/kernel/smp.c              | 12 ----------
> > >  arch/powerpc/platforms/pseries/dlpar.c | 40 +++++++++++++---------------------
> > >  arch/x86/Kconfig                       |  4 ----
> > >  arch/x86/kernel/smpboot.c              | 21 ------------------
> > >  arch/x86/kernel/topology.c             | 11 ++++++----
> > >  drivers/base/cpu.c                     | 26 ++++++++++++----------
> > >  include/linux/cpu.h                    | 13 -----------
> > >  7 files changed, 37 insertions(+), 90 deletions(-)
> > > --
> > > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> > > the body of a message to majordomo@...r.kernel.org
> > > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > > Please read the FAQ at  http://www.tux.org/lkml/
> 
> 
-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/