linux-kernel - Re: [PATCH V2] PCI: exynos: add support for MSI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <003001cea472$3d6ffee0$b84ffca0$%han@samsung.com>
Date:	Thu, 29 Aug 2013 13:43:00 +0900
From:	Jingoo Han <jg1.han@...sung.com>
To:	'Pratyush Anand' <pratyush.anand@...com>
Cc:	'Bjorn Helgaas' <bhelgaas@...gle.com>, linux-pci@...r.kernel.org,
	linux-samsung-soc@...r.kernel.org,
	'Kukjin Kim' <kgene.kim@...sung.com>,
	'Mohit KUMAR DCG' <Mohit.KUMAR@...com>,
	'Siva Reddy Kallam' <siva.kallam@...sung.com>,
	'SRIKANTH TUMKUR SHIVANAND' <ts.srikanth@...sung.com>,
	'Arnd Bergmann' <arnd@...db.de>,
	'Sean Cross' <xobs@...agi.com>,
	'Kishon Vijay Abraham I' <kishon@...com>,
	'Thierry Reding' <thierry.reding@...il.com>,
	'Thomas Petazzoni' <thomas.petazzoni@...e-electrons.com>,
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
	'Jingoo Han' <jg1.han@...sung.com>
Subject: Re: [PATCH V2] PCI: exynos: add support for MSI

On Thursday, August 29, 2013 12:45 PM, Pratyush Anand wrote:
> On Wed, Aug 28, 2013 at 04:17:24PM +0800, Jingoo Han wrote:
> > On Friday, August 23, 2013 5:36 PM, Pratyush Anand wrote:
> > > On Fri, Aug 23, 2013 at 02:04:20PM +0800, Jingoo Han wrote:
> >
> 
> [...]
> 
> > > #define MAX_PCIE_PORT_SUPPORTED 3
> > > static DECLARE_BITMAP(msi_irq_in_use[MAX_PCIE_PORT_SUPPORTED],
> > >                   NUM_MSI_IRQS);
> > > static unsigned int *msi_data[MAX_PCIE_PORT_SUPPORTED];
> >
> > No, there is no need to do it.
> > Without this, we can use 3 RCs by adding a node of 3rd RC to dt file.
> >
> 
> Yes, you can use RCs by adding nodes to dt file. But you will need one
> msi_irq_in_use and one msi_data per RC (ie per port in this driver), isn't it?

Aha, you're right.

A few minutes ago, I found the same value of msi_data is
used for 2 different RCs. It is my fault.

As you mentioned, one msi_data per RC should be used.
I will modify it in order to use one msi_data per RC.

Thank you for your kind description. :-)

Best regards,
Jingoo Han


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/