linux-kernel - Re: [PATCH RFC v2 14/16] ARM: vexpress: remove custom .init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130830113918.GV6617@n2100.arm.linux.org.uk>
Date:	Fri, 30 Aug 2013 12:39:18 +0100
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	"Jon Medhurst (Tixy)" <tixy@...aro.org>
Cc:	Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
	Arnd Bergmann <arnd@...db.de>, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	Pawel Moll <Pawel.Moll@....com>
Subject: Re: [PATCH RFC v2 14/16] ARM: vexpress: remove custom .init_time
	hook

On Fri, Aug 30, 2013 at 11:02:31AM +0100, Jon Medhurst (Tixy) wrote:
> After adding of_clk_init(NULL) to time_init() things boot OK for me with
> this patch. However, do we know that sched_clock is never going to get
> read before time_init() has actually started the clock it reads? Are we
> making things more fragile?

As I've been saying for years, sched_clock gets read for the first time
in sched_init() -> init_idle() which occurs before time_init().

Whether that matters or not is debatable, but the first read should return
zero, and it will return zero after initialization - so I think all we end
up losing is some accounting of the time taken in the early kernel boot.

If we wish to talk about correctness, then arguably it isn't correct.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/