linux-kernel - Re: [PATCH 0/2] vgaarb: Fixes for partial VGA opt-out

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130830124119.GH11428@intel.com>
Date:	Fri, 30 Aug 2013 15:41:19 +0300
From:	Ville Syrjälä <ville.syrjala@...ux.intel.com>
To:	Alex Williamson <alex.williamson@...hat.com>
Cc:	linux-kernel@...r.kernel.org, airlied@...hat.com,
	intel-gfx@...ts.freedesktop.org
Subject: Re: [PATCH 0/2] vgaarb: Fixes for partial VGA opt-out

On Thu, Aug 15, 2013 at 04:37:47PM -0600, Alex Williamson wrote:
> I'm trying to add support for VGA arbitration on newer Intel graphics
> devices.  The existing code attempts to do this, but appear to have
> not been updated since GMCH devices roamed the Earth.  On newer
> devices like Haswell, we can disable VGA memory through an MSR on the
> device, but we rely on the VGA arbiter to manage VGA IO using the PCI
> COMMAND register.  In trying to unregister legacy VGA memory, I found
> that the VGA arbiter still wanted to disable both memory and IO on
> the device and that it forgot to actually program the device to
> disable IO when the decoding is updated.  This series attempts to fix
> both of those.  Thanks,

The series looks good to me.

Reviewed-by: Ville Syrjälä <ville.syrjala@...ux.intel.com>

> 
> Alex
> 
> ---
> 
> Alex Williamson (2):
>       vgaarb: Don't disable resources that are not owned
>       vgaarb: Fix VGA decodes changes
> 
> 
>  drivers/gpu/vga/vgaarb.c |   50 ++++++++++++++++++++--------------------------
>  1 file changed, 22 insertions(+), 28 deletions(-)

-- 
Ville Syrjälä
Intel OTC
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/