| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20130830124518.68BBA3E102A@localhost> Date: Fri, 30 Aug 2013 13:45:18 +0100 From: Grant Likely <grant.likely@...retlab.ca> To: Mark Salter <msalter@...hat.com>, Roy Franz <roy.franz@...aro.org> Cc: linux-kernel@...r.kernel.org, linux-efi@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, matt.fleming@...el.com, linux@....linux.org.uk, leif.lindholm@...aro.org, dave.martin@....com Subject: Re: [PATCH 01/16] Move common EFI stub code from x86 arch code to common location On Tue, 13 Aug 2013 09:56:20 -0400, Mark Salter <msalter@...hat.com> wrote: > On Fri, 2013-08-09 at 16:26 -0700, Roy Franz wrote: > > No code changes made, just moving functions from x86 arch directory > > to common location. > > Code is shared using #include, similar to how decompression code > > is shared among architectures. > > > > Signed-off-by: Roy Franz <roy.franz@...aro.org> > > --- > > Tested on arm64. > > Acked-by: Mark Salter <msalter@...hat.com> Looks okay to me. I'm not a big fan of #including .c files, but I'm okay with it as-is for the time being. It can be revisited later to investigate a clean way to compile these functions as a separate .o file. Reviewed-by: Grant Likely <grant.likely@...aro.org> g. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists