linux-kernel - Re: [PATCH 08/16] Generalize handle_ramdisks() and rename to handle_cmdline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130830133138.AEFF83E102A@localhost>
Date:	Fri, 30 Aug 2013 14:31:38 +0100
From:	Grant Likely <grant.likely@...retlab.ca>
To:	Roy Franz <roy.franz@...aro.org>, linux-kernel@...r.kernel.org,
	linux-efi@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	matt.fleming@...el.com, linux@....linux.org.uk
Cc:	leif.lindholm@...aro.org, dave.martin@....com, msalter@...hat.com,
	Roy Franz <roy.franz@...aro.org>
Subject: Re: [PATCH 08/16] Generalize handle_ramdisks() and rename to handle_cmdline_files().

On Fri,  9 Aug 2013 16:26:09 -0700, Roy Franz <roy.franz@...aro.org> wrote:
> The handle_cmdline_files now takes the option to handle as a string,
> and returns the loaded data through parameters, rather than taking
> an x86 specific setup_header structure.  For ARM, this will be used
> to load a device tree blob in addition to initrd images.
> 
> Signed-off-by: Roy Franz <roy.franz@...aro.org>

Minor comment below, but otherwise looks good:

Reviewed-by: Grant Likely <grant.likely@...aro.org>

> ---
> @@ -380,7 +388,7 @@ static efi_status_t handle_ramdisks(efi_system_table_t *sys_table_arg,
>  		status = efi_call_phys5(fh->open, fh, &h, filename_16,
>  					EFI_FILE_MODE_READ, (u64)0);
>  		if (status != EFI_SUCCESS) {
> -			efi_printk(sys_table_arg, "Failed to open initrd file: ");
> +			efi_printk(sys_table_arg, "Failed to open file file: ");

"file file:"? Search and replace artifact?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/