linux-kernel - Re: [PATCH] HID: usbhid: quirk for N-Trig DuoSense Touch Screen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABSveYhSMyCxPZS3nqSdiG-UZwAMMTX7UjgFG=emY+L-K60sdQ@mail.gmail.com>
Date:	Fri, 30 Aug 2013 15:34:11 -0400
From:	Vasily Titskiy <qehgt0@...il.com>
To:	Benjamin Tissoires <benjamin.tissoires@...il.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	linux-input <linux-input@...r.kernel.org>,
	Jiri Kosina <jkosina@...e.cz>
Subject: Re: [PATCH] HID: usbhid: quirk for N-Trig DuoSense Touch Screen

Hi,

I've re-tested it with HID_QUIRK_NO_INIT_REPORTS parameter. Looks
fine, still no delays.

Shoud I re-format & re-submit the patch?
  Vasily Titskiy


On Fri, Aug 30, 2013 at 3:18 PM, Benjamin Tissoires
<benjamin.tissoires@...il.com> wrote:
> Hi,
>
> first, for the next submission, do not forget to add Jiri (the HID
> maintainer) in CC, otherwise there are huge chances that he will miss
> your patch.
>
> On Fri, Aug 30, 2013 at 8:47 PM, Vasily Titskiy <qehgt0@...il.com> wrote:
>> The DuoSense touchscreen device causes a 10 second timeout. This fix
>> removes the delay.
>>
>> Signed-off-by: Vasily Titskiy <qehgt0@...il.com>
>> ---
>>  drivers/hid/hid-ids.h           |    2 ++
>>  drivers/hid/usbhid/hid-quirks.c |    3 +++
>>  2 files changed, 5 insertions(+)
>>
>> diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
>> index 2168885..c3929ea 100644
>> --- a/drivers/hid/hid-ids.h
>> +++ b/drivers/hid/hid-ids.h
>> @@ -898,4 +898,6 @@
>>  #define USB_VENDOR_ID_PRIMAX 0x0461
>>  #define USB_DEVICE_ID_PRIMAX_KEYBOARD 0x4e05
>>
>> +#define USB_DEVICE_ID_NTRIG_DUOSENSE 0x1500
>> +
>
> Please keep the list sorted. This define should go into the *_NTRIG_* block.
>
>>  #endif
>> diff --git a/drivers/hid/usbhid/hid-quirks.c b/drivers/hid/usbhid/hid-quirks.c
>> index 19b8360..3fd4dfd 100644
>> --- a/drivers/hid/usbhid/hid-quirks.c
>> +++ b/drivers/hid/usbhid/hid-quirks.c
>> @@ -89,6 +89,9 @@ static const struct hid_blacklist {
>>   { USB_VENDOR_ID_SYMBOL, USB_DEVICE_ID_SYMBOL_SCANNER_2, HID_QUIRK_NOGET },
>>   { USB_VENDOR_ID_TPV, USB_DEVICE_ID_TPV_OPTICAL_TOUCHSCREEN, HID_QUIRK_NOGET },
>>   { USB_VENDOR_ID_TURBOX, USB_DEVICE_ID_TURBOX_KEYBOARD, HID_QUIRK_NOGET },
>> +
>
> extra whitespace
>
>> + { USB_VENDOR_ID_NTRIG, USB_DEVICE_ID_NTRIG_DUOSENSE, HID_QUIRK_NOGET },
>
> I'm sure we could try here the new quirk
> HID_QUIRK_NO_INIT_INPUT_REPORTS, this would be more accurate I think.
> At least can you test if HID_QUIRK_NO_INIT_REPORTS is enough?
> HID_QUIRK_NOGET prevent all request from the host to the device, which
> is a little bit too much in many cases.
>
>> +
>
> extra whitespace too.
>
> Cheers,
> Benjamin
>
>
>>   { USB_VENDOR_ID_UCLOGIC, USB_DEVICE_ID_UCLOGIC_TABLET_PF1209,
>> HID_QUIRK_MULTI_INPUT },
>>   { USB_VENDOR_ID_UCLOGIC, USB_DEVICE_ID_UCLOGIC_TABLET_WP4030U,
>> HID_QUIRK_MULTI_INPUT },
>>   { USB_VENDOR_ID_UCLOGIC, USB_DEVICE_ID_UCLOGIC_TABLET_KNA5,
>> HID_QUIRK_MULTI_INPUT },
>> --
>> 1.7.10.4
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-input" in
>> the body of a message to majordomo@...r.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/