linux-kernel - Re: [PATCH] x86: e820: fix memmap kernel boot parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <52210314.4080408@zytor.com>
Date:	Fri, 30 Aug 2013 13:39:48 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Bob Liu <lliubbo@...il.com>
CC:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	hpa@...ux.intel.com, yinghai@...nel.org, jacob.shin@....com,
	konrad.wilk@...cle.com, linux-mm@...ck.org,
	Bob Liu <bob.liu@...cle.com>
Subject: Re: [PATCH] x86: e820: fix memmap kernel boot parameter

On 08/29/2013 10:47 PM, Bob Liu wrote:
> Kernel boot parameter memmap=nn[KMG]$ss[KMG] is used to mark specific memory as
> reserved. Region of memory to be used is from ss to ss+nn.
> 
> But I found the action of this parameter is not as expected.
> I tried on two machines.
> Machine1: bootcmdline in grub.cfg "memmap=800M$0x60bfdfff", but the result of
> "cat /proc/cmdline" changed to "memmap=800M/bin/bashx60bfdfff" after system
> booted.
> 
> Machine2: bootcmdline in grub.cfg "memmap=0x77ffffff$0x880000000", the result of
> "cat /proc/cmdline" changed to "memmap=0x77ffffffx880000000".
> 
> I didn't find the root cause, I think maybe grub reserved "$0" as something
> special.
> Replace '$' with '%' in kernel boot parameter can fix this issue.

NAK for the reasons already discussed.

	-hpa


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/