linux-kernel - Re: [PATCH] Staging:BCM:DDRInit.c:Renaming __FUNCTION_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 31 Aug 2013 14:04:59 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Paul McQuade <paulmcquad@...il.com>
Cc:	gregkh@...uxfoundation.org,
	Linux-kernel <linux-kernel@...r.kernel.org>,
	Linux-Devel <devel@...verdev.osuosl.org>
Subject: Re: [PATCH] Staging:BCM:DDRInit.c:Renaming __FUNCTION__

On Fri, Aug 30, 2013 at 06:49:16PM +0100, Paul McQuade wrote:
> >From c21d0da84c92d351f37b70c0d9c01a66fcb84e88 Mon Sep 17 00:00:00 2001
> From: Paul McQuade <paulmcquad@...il.com>
> Date: Thu, 15 Aug 2013 20:00:50 +0100
> Subject: [PATCH] Staging:BCM:DDRInit.c:Renaming __FUNCTION__
> 

Don't put these in the patch description.

> __Function__ gets renamed with __func__
> 

__FUNCTION__

You have some other changes as well like white space changes to
surrounding lines.  Put those in a separate patch.


>  				retval = wrmalt(Adapter,(UINT)0x0f000830, &uiResetValue, sizeof(uiResetValue));
>  				if(retval < 0) {
> -					BCM_DEBUG_PRINT(Adapter,CMHOST, WRM, DBG_LVL_ALL, "%s:%d WRM failed\n", __FUNCTION__, __LINE__);
> +					BCM_DEBUG_PRINT(Adapter, CMHOST, RDM, DBG_LVL_ALL, "%s:%d RDM failed\n", __func__, __LINE__);
>  					return retval;
>  				}

Here you changed the WRM to RDM.  That can fall under the trivial and
closely related change but it needs to be mentioned in the changelog.
Except in this case the original message was correct and the new message
is wrong.  W stands for "write" and R stands for "read".

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/