| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <5221F1D9.9030001@gmail.com>
Date: Sat, 31 Aug 2013 15:38:33 +0200
From: Martin MOKREJŠ <mmokrejs@...il.com>
To: Dan Aloni <alonid@...atoscale.com>, akpm@...ux-foundation.org
CC: linux-kernel@...r.kernel.org, gregkh@...uxfoundation.org,
Al Viro <viro@...iv.linux.org.uk>,
Denys Vlasenko <vda.linux@...glemail.com>,
Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH linux-next] Prevent a coredump with a large vm_map_count
from Oopsing
Hi Dan,
thank you for your work on my issue. I would like to test it on 3.10.9 where
I faced the problem initially.
linux-3.10.9 # patch -p1 < ../patches/vm_map_count.patch
patching file fs/binfmt_elf.c
Hunk #1 succeeded at 1415 (offset -14 lines).
Hunk #2 succeeded at 1430 (offset -14 lines).
Hunk #3 succeeded at 1487 (offset -14 lines).
Hunk #4 succeeded at 1609 (offset -14 lines).
Hunk #5 succeeded at 1689 (offset -14 lines).
Hunk #6 FAILED at 1737.
Hunk #7 succeeded at 1810 (offset -14 lines).
Hunk #8 succeeded at 1854 (offset -14 lines).
Hunk #9 succeeded at 1902 (offset -14 lines).
Hunk #10 succeeded at 1970 (offset -14 lines).
Hunk #11 FAILED at 2068.
2 out of 11 hunks FAILED -- saving rejects to file fs/binfmt_elf.c.rej
#
Thank you.
Dan Aloni wrote:
> A high setting of max_map_count, and a process core-dumping with
> a large enough vm_map_count could result in an NT_FILE note not
> being written, and the kernel crashing immediately later because
> it has assumed otherwise.
>
> Reproduction of the bug described here:
>
> https://lkml.org/lkml/2013/8/30/50
>
> Issue originating in 2aa362c49 (from Oct 4, 2012).
>
> This patch make that section optional in that case.
> fill_files_note() should signify the error, and also let the info
> struct in elf_core_dump() be zero-initialized so that we can check
> for the optionally written note.
>
> Cc'ed original signers.
>
> Cc'ed Al Viro because it is trivially relies on his linux-next
> tree changes.
>
> Signed-off-by: Dan Aloni <alonid@...atoscale.com>
> Cc: Al Viro <viro@...iv.linux.org.uk>
> Cc: Denys Vlasenko <vda.linux@...glemail.com>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: Linus Torvalds <torvalds@...ux-foundation.org>
> ---
> fs/binfmt_elf.c | 33 +++++++++++++++++++++------------
> 1 file changed, 21 insertions(+), 12 deletions(-)
>
> diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c
> index dc82279..e1a323a 100644
> --- a/fs/binfmt_elf.c
> +++ b/fs/binfmt_elf.c
> @@ -1429,7 +1429,7 @@ static void fill_siginfo_note(struct memelfnote *note, user_siginfo_t *csigdata,
> * long file_ofs
> * followed by COUNT filenames in ASCII: "FILE1" NUL "FILE2" NUL...
> */
> -static void fill_files_note(struct memelfnote *note)
> +static int fill_files_note(struct memelfnote *note)
> {
> struct vm_area_struct *vma;
> unsigned count, size, names_ofs, remaining, n;
> @@ -1444,11 +1444,11 @@ static void fill_files_note(struct memelfnote *note)
> names_ofs = (2 + 3 * count) * sizeof(data[0]);
> alloc:
> if (size >= MAX_FILE_NOTE_SIZE) /* paranoia check */
> - goto err;
> + return -E2BIG;
> size = round_up(size, PAGE_SIZE);
> data = vmalloc(size);
> if (!data)
> - goto err;
> + return -ENOMEM;
>
> start_end_ofs = data + 2;
> name_base = name_curpos = ((char *)data) + names_ofs;
> @@ -1501,7 +1501,7 @@ static void fill_files_note(struct memelfnote *note)
>
> size = name_curpos - (char *)data;
> fill_note(note, "CORE", NT_FILE, size, data);
> - err: ;
> + return 0;
> }
>
> #ifdef CORE_DUMP_USE_REGSET
> @@ -1623,6 +1623,7 @@ static int fill_note_info(struct elfhdr *elf, int phdrs,
> struct elf_prpsinfo *psinfo;
> struct core_thread *ct;
> unsigned int i;
> + int ret;
>
> info->size = 0;
> info->thread = NULL;
> @@ -1702,8 +1703,9 @@ static int fill_note_info(struct elfhdr *elf, int phdrs,
> fill_auxv_note(&info->auxv, current->mm);
> info->size += notesize(&info->auxv);
>
> - fill_files_note(&info->files);
> - info->size += notesize(&info->files);
> + ret = fill_files_note(&info->files);
> + if (!ret)
> + info->size += notesize(&info->files);
>
> return 1;
> }
> @@ -1735,7 +1737,7 @@ static int write_note_info(struct elf_note_info *info,
> return 0;
> if (first && !writenote(&info->auxv, cprm))
> return 0;
> - if (first && !writenote(&info->files, cprm))
> + if (first && info->files.data && !writenote(&info->files, cprm))
> return 0;
>
> for (i = 1; i < info->thread_notes; ++i)
> @@ -1822,6 +1824,7 @@ static int elf_dump_thread_status(long signr, struct elf_thread_status *t)
>
> struct elf_note_info {
> struct memelfnote *notes;
> + struct memelfnote *notes_files;
> struct elf_prstatus *prstatus; /* NT_PRSTATUS */
> struct elf_prpsinfo *psinfo; /* NT_PRPSINFO */
> struct list_head thread_list;
> @@ -1865,6 +1868,7 @@ static int fill_note_info(struct elfhdr *elf, int phdrs,
> siginfo_t *siginfo, struct pt_regs *regs)
> {
> struct list_head *t;
> + int ret;
>
> if (!elf_note_info_init(info))
> return 0;
> @@ -1912,9 +1916,13 @@ static int fill_note_info(struct elfhdr *elf, int phdrs,
>
> fill_siginfo_note(info->notes + 2, &info->csigdata, siginfo);
> fill_auxv_note(info->notes + 3, current->mm);
> - fill_files_note(info->notes + 4);
> + info->numnote = 4;
>
> - info->numnote = 5;
> + ret = fill_files_note(info->notes + info->numnote);
> + if (!ret) {
> + info->notes_files = info->notes + info->numnote;
> + info->numnote++;
> + }
>
> /* Try to dump the FPU. */
> info->prstatus->pr_fpvalid = elf_core_copy_task_fpregs(current, regs,
> @@ -1976,8 +1984,9 @@ static void free_note_info(struct elf_note_info *info)
> kfree(list_entry(tmp, struct elf_thread_status, list));
> }
>
> - /* Free data allocated by fill_files_note(): */
> - vfree(info->notes[4].data);
> + /* Free data possibly allocated by fill_files_note(): */
> + if (info->notes_files)
> + vfree(info->notes_files->data);
>
> kfree(info->prstatus);
> kfree(info->psinfo);
> @@ -2059,7 +2068,7 @@ static int elf_core_dump(struct coredump_params *cprm)
> struct vm_area_struct *vma, *gate_vma;
> struct elfhdr *elf = NULL;
> loff_t offset = 0, dataoff;
> - struct elf_note_info info;
> + struct elf_note_info info = {0, };
> struct elf_phdr *phdr4note = NULL;
> struct elf_shdr *shdr4extnum = NULL;
> Elf_Half e_phnum;
>
--
Martin Mokrejs, Ph.D.
Bioinformatics
Donovalska 1658
149 00 Prague
Czech Republic
http://www.iresite.org
http://www.iresite.org/~mmokrejs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists