linux-kernel - Re: [PATCH v7 1/4] spinlock: A new lockref structure for lockless update of refcount

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 30 Aug 2013 22:02:36 -0400
From:	Waiman Long <waiman.long@...com>
To:	Al Viro <viro@...IV.linux.org.uk>
CC:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Ingo Molnar <mingo@...nel.org>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Jeff Layton <jlayton@...hat.com>,
	Miklos Szeredi <mszeredi@...e.cz>,
	Ingo Molnar <mingo@...hat.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	linux-fsdevel <linux-fsdevel@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	Andi Kleen <andi@...stfloor.org>,
	"Chandramouleeswaran, Aswin" <aswin@...com>,
	"Norton, Scott J" <scott.norton@...com>
Subject: Re: [PATCH v7 1/4] spinlock: A new lockref structure for lockless
 update of refcount

On 08/30/2013 04:48 PM, Al Viro wrote:
> On Fri, Aug 30, 2013 at 04:35:49PM -0400, Waiman Long wrote:
>
>> The AIM7 test was run on a set of 16 ramdisk formated with ext3
>> filesystem with the following mount options:
>> barrier=0,async,noatime,nodiratime. Maybe that is a factor.
> I would be really surprised if it was...  Could you slap the following
> into __fput():
>
> 	struct mount *m = real_mount(mnt);
> 	if (unlikely(!m->mnt_ns)) {
> 		printk(KERN_INFO "type = %s",
> 			mnt->mnt_sb->s_type->name);
> 		WARN_ON(1);
> 	}
> and see what it catches?  That'll need #include "fs/mount.h" in
> fs/file_table.c to compile...

I slapped in the code segment, and the following was logged:

[  340.871590] type = tmpfs
[  340.871596] ------------[ cut here ]------------
[  340.871606] WARNING: CPU: 37 PID: 63276 at fs/file_table.c:239 
__fput+0x23d/0x270()
[  340.871607] Modules linked in: brd(F) ip6table_filter(F) 
ip6_tables(F) iptable_filter(F) ip_tables(F) ebtable_nat(F) ebtables(F) 
x_tables(F) edd(F) af_packet(F) bridge(F) stp(F) llc(F) 
cpufreq_conservative(F) cpufreq_userspace(F) cpufreq_powersave(F) 
pcc_cpufreq(F) microcode(F) fuse(F) loop(F) vhost_net(F) macvtap(F) 
macvlan(F) vhost(F) tun(F) kvm_intel(F) ipv6(F) kvm(F) iTCO_wdt(F) 
iTCO_vendor_support(F) joydev(F) igb(F) tpm_infineon(F) dca(F) ptp(F) 
hid_generic(F) i7core_edac(F) sr_mod(F) tpm_tis(F) pps_core(F) qlcnic(F) 
tpm(F) edac_core(F) be2net(F) netxen_nic(F) lpc_ich(F) ehci_pci(F) 
mfd_core(F) hpwdt(F) hpilo(F) pcspkr(F) serio_raw(F) cdrom(F) 
tpm_bios(F) sg(F) rtc_cmos(F) mperf(F) button(F) acpi_power_meter(F) 
ext3(F) jbd(F) mbcache(F) dm_mirror(F) dm_region_hash(F) dm_log(F) 
linear(F) radeon(F) ttm(F) drm_kms_helper(F) drm(F) i2c_algo_bit(F) 
i2c_core(F) usbhid(F) hid(F) uhci_hcd(F) ehci_hcd(F) usbcore(F) 
qla2xxx(F) sd_mod(F) usb_common(F) thermal(F) processor(F) 
thermal_sys(F) hwmon(F) scsi_dh_emc(F) scsi_dh_rdac(F) scsi_dh_hp_sw(F) 
scsi_dh_alua(F) scsi_dh(F) dm_snapshot(F) dm_mod(F) ata_generic(F) 
ata_piix(F) libata(F) hpsa(F) lpfc(F) scsi_transport_fc(F) scsi_tgt(F) 
crc_t10dif(F) cciss(F) scsi_mod(F)
[  340.871663] CPU: 37 PID: 63276 Comm: reaim Tainted: GF       W    
3.11.0-rc7-lockref-0.11-default #4
[  340.871665] Hardware name: HP ProLiant DL980 G7, BIOS P66 07/30/2012
[  340.871667]  00000000000000ef ffff899f6b03dd88 ffffffff814992f5 
ffff899f6b03ddc8
[  340.871681]  ffffffff8104a187 ffff899f6b03dda8 0000000000000000 
ffff899f6b03aa40
[  340.871686]  ffff899f68fc7cc0 ffff899f69ee8ae0 ffff899f69ee8ae0 
ffff899f6b03ddd8
[  340.871692] Call Trace:
[  340.871700]  [<ffffffff814992f5>] dump_stack+0x6a/0x7d
[  340.871705]  [<ffffffff8104a187>] warn_slowpath_common+0x87/0xb0
[  340.871709]  [<ffffffff8104a1c5>] warn_slowpath_null+0x15/0x20
[  340.871712]  [<ffffffff8116c5bd>] __fput+0x23d/0x270
[  340.871715]  [<ffffffff8116c699>] ____fput+0x9/0x10
[  340.871719]  [<ffffffff81068ae1>] task_work_run+0xb1/0xe0
[  340.871724]  [<ffffffff81002990>] do_notify_resume+0x80/0x1b0
[  340.871728]  [<ffffffff811ed120>] ? ipc_lock+0x30/0x50
[  340.871732]  [<ffffffff8113a356>] ? remove_vma+0x56/0x60
[  340.871736]  [<ffffffff8113c1bf>] ? do_munmap+0x34f/0x380
[  340.871741]  [<ffffffff814a5fda>] int_signal+0x12/0x17
[  340.871744] ---[ end trace aafa6c45f3388d65 ]---

Regards,
Longman
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/