linux-kernel - [PATCH 2/3] driver: input: twl4030-vibra: fix missing of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <522190ED.6020909@huawei.com>
Date:	Sat, 31 Aug 2013 14:45:01 +0800
From:	Libo Chen <clbchenlibo.chen@...wei.com>
To:	<dmitry.torokhov@...il.com>
CC:	<peter.ujfalusi@...com>, Bill Pemberton <wfp5p@...ginia.edu>,
	<broonie@...nsource.wolfsonmicro.com>,
	<linux-input@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>
Subject: [PATCH 2/3] driver: input: twl4030-vibra: fix missing of_node_put


decrease node device_node refcount after task completion

Signed-off-by: Libo Chen <libo.chen@...wei.com>
---
 drivers/input/misc/twl4030-vibra.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/drivers/input/misc/twl4030-vibra.c b/drivers/input/misc/twl4030-vibra.c
index 68a5f33..b8d1526 100644
--- a/drivers/input/misc/twl4030-vibra.c
+++ b/drivers/input/misc/twl4030-vibra.c
@@ -185,8 +185,10 @@ static bool twl4030_vibra_check_coexist(struct twl4030_vibra_data *pdata,
 	if (pdata && pdata->coexist)
 		return true;

-	if (of_find_node_by_name(node, "codec"))
+	if (of_find_node_by_name(node, "codec")) {
+		of_node_put(node);
 		return true;
+	}

 	return false;
 }
-- 
1.7.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/