lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 31 Aug 2013 14:44:57 +0800 From: Libo Chen <clbchenlibo.chen@...wei.com> To: <dmitry.torokhov@...il.com> CC: <peter.ujfalusi@...com>, Bill Pemberton <wfp5p@...ginia.edu>, <broonie@...nsource.wolfsonmicro.com>, <linux-input@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>, Li Zefan <lizefan@...wei.com>, "zhangwei(Jovi)" <jovi.zhangwei@...wei.com> Subject: [PATCH 1/3] driver: input: 88pm860x-ts: fix missing of_node_put decrease np device_node refcount after task completion Signed-off-by: Libo Chen <libo.chen@...wei.com> --- drivers/input/touchscreen/88pm860x-ts.c | 22 +++++++++++++++------- 1 files changed, 15 insertions(+), 7 deletions(-) diff --git a/drivers/input/touchscreen/88pm860x-ts.c b/drivers/input/touchscreen/88pm860x-ts.c index f7de14a..4a2fd46 100644 --- a/drivers/input/touchscreen/88pm860x-ts.c +++ b/drivers/input/touchscreen/88pm860x-ts.c @@ -142,14 +142,18 @@ static int pm860x_touch_dt_init(struct platform_device *pdev, data |= (n << 7) & PM8607_GPADC_SW_CAL_MASK; if (data) { ret = pm860x_reg_write(i2c, PM8607_GPADC_MISC1, data); - if (ret < 0) - return -EINVAL; + if (ret < 0) { + ret = -EINVAL; + goto err; + } } /* set tsi prebias time */ if (!of_property_read_u32(np, "marvell,88pm860x-tsi-prebias", &data)) { ret = pm860x_reg_write(i2c, PM8607_TSI_PREBIAS, data); - if (ret < 0) - return -EINVAL; + if (ret < 0) { + ret = -EINVAL; + goto err; + } } /* set prebias & prechg time of pen detect */ data = 0; @@ -159,11 +163,15 @@ static int pm860x_touch_dt_init(struct platform_device *pdev, data |= n & PM8607_PD_PRECHG_MASK; if (data) { ret = pm860x_reg_write(i2c, PM8607_PD_PREBIAS, data); - if (ret < 0) - return -EINVAL; + if (ret < 0) { + ret = -EINVAL; + goto err; + } } of_property_read_u32(np, "marvell,88pm860x-resistor-X", res_x); - return 0; +err: + of_node_put(np); + return ret; } #else #define pm860x_touch_dt_init(x, y, z) (-1) -- 1.7.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists