linux-kernel - Re: [PATCH v3] x86: avoid remapping data in parse_setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5223CA9C.5020505@zytor.com>
Date:	Sun, 01 Sep 2013 16:15:40 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Linn Crosetto <linn@...com>
CC:	tglx@...utronix.de, mingo@...hat.com, x86@...nel.org,
	paulmck@...ux.vnet.ibm.com, dhowells@...hat.com,
	mtk.manpages@...il.com, yinghai@...nel.org, penberg@...nel.org,
	jacob.shin@....com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] x86: avoid remapping data in parse_setup_data()

On 08/13/2013 02:46 PM, Linn Crosetto wrote:
> Type SETUP_PCI, added by setup_efi_pci(), may advertise a ROM size
> larger than early_memremap() is able to handle, which is currently
> limited to 256kB. If this occurs it leads to a NULL dereference in
> parse_setup_data().
> 
> To avoid this, remap the setup_data header and allow parsing functions
> for individual types to handle their own data remapping.
> 
> Signed-off-by: Linn Crosetto <linn@...com>

So it seems this patch generates some new sparse warnings.  Can you
please create an incremental fixup patch to address those sparse
warnings?  (See email from Fengguang Wu's robot.)

	-hpa


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/