linux-kernel - Re: [PATCH] drivers: misc: bmp085: remove '__init' from mp085_get_of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <522444C3.3000701@asianux.com>
Date:	Mon, 02 Sep 2013 15:56:51 +0800
From:	Chen Gang <gang.chen@...anux.com>
To:	Arnd Bergmann <arnd@...db.de>
CC:	Greg KH <gregkh@...uxfoundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drivers: misc: bmp085: remove '__init' from mp085_get_of_properties()


It seems the "./scripts/get_maintainer.pl" is not quite precise, it
lead me to send this mail to kernel mailing list, not to drivers
related mailing list.

  [root@...enlinux linux-next]# ./scripts/get_maintainer.pl /tmp/0001-drivers-misc-bmp085-remove-__init-from-mp085_get_of_.patch 
  Arnd Bergmann <arnd@...db.de> (supporter:CHAR and MISC DRI...)
  Greg Kroah-Hartman <gregkh@...uxfoundation.org> (supporter:CHAR and MISC DRI...)
  linux-kernel@...r.kernel.org (open list)

Thanks.

On 09/02/2013 03:54 PM, Chen Gang wrote:
> bmp085_get_of_properties() is called by bmp085_init_client() which is
> called by bmp085_probe() which is an EXPORT_SYMBOL_GPL function.
> 
> bmp085_probe() is really used as a probe function by another modules
> (e.g. bmp085-i2c.c, bmp085-spi.c).
> 
> Except bmp085_get_of_properties(), all functions have no '__init', so
> need remove '__init' from bmp085_get_of_properties() too, or at least,
> it will report related warning:
> 
>   WARNING: vmlinux.o(.text+0x4c8a07): Section mismatch in reference from the variable .LM171 to the variable .init.text:_bmp085_get_of_properties
>   The function .LM171() references
>   the variable __init _bmp085_get_of_properties.
>   This is often because .LM171 lacks a __init
>   annotation or the annotation of _bmp085_get_of_properties is wrong.
> 
> 
> Signed-off-by: Chen Gang <gang.chen@...anux.com>
> ---
>  drivers/misc/bmp085.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/misc/bmp085.c b/drivers/misc/bmp085.c
> index 849e2fe..2704d88 100644
> --- a/drivers/misc/bmp085.c
> +++ b/drivers/misc/bmp085.c
> @@ -374,7 +374,7 @@ int bmp085_detect(struct device *dev)
>  }
>  EXPORT_SYMBOL_GPL(bmp085_detect);
>  
> -static void __init bmp085_get_of_properties(struct bmp085_data *data)
> +static void bmp085_get_of_properties(struct bmp085_data *data)
>  {
>  #ifdef CONFIG_OF
>  	struct device_node *np = data->dev->of_node;
> 


-- 
Chen Gang
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/