linux-kernel - Re: [PATCH 2/3] extcon: Change field type of 'dev' in extcon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130902003807.GA10709@kroah.com>
Date:	Sun, 1 Sep 2013 17:38:07 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Chanwoo Choi <cw00.choi@...sung.com>
Cc:	linux-kernel@...r.kernel.org, myungjoo.ham@...sung.com,
	kyungmin.park@...sung.com
Subject: Re: [PATCH 2/3] extcon: Change field type of 'dev' in extcon_dev
 structure

On Mon, Sep 02, 2013 at 09:20:07AM +0900, Chanwoo Choi wrote:
> -	edev->dev = kzalloc(sizeof(struct device), GFP_KERNEL);
> -	if (!edev->dev)
> -		return -ENOMEM;
> -	edev->dev->parent = dev;
> -	edev->dev->class = extcon_class;
> -	edev->dev->release = extcon_dev_release;
> +	edev->dev.parent = dev;
> +	edev->dev.class = extcon_class;
> +	edev->dev.release = extcon_dev_release;

You didn't change extcon_dev_release() to properly free all of the
memory you allocated here, otherwise the slab allocator will oops when
you try to call it...

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/