linux-kernel - Please discard "checkpatch: warn when using extern with function prototypes in .h files"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <9606.1378129893@warthog.procyon.org.uk>
Date:	Mon, 02 Sep 2013 14:51:33 +0100
From:	David Howells <dhowells@...hat.com>
To:	joe@...ches.com, akpm@...ux-foundation.org,
	hannes@...essinduktion.org
cc:	dhowells@...hat.com, linux-kernel@...r.kernel.org,
	dwmw2@...radead.org
Subject: Please discard "checkpatch: warn when using extern with function prototypes in .h files"


I noticed that a patch got committed to checkpatch to complain about function
prototypes prefixed by "extern".

Please discard/revert this patch:

	commit 7cd0f806622836e386ef18ad1950a9a729803019
	Author: Joe Perches <joe@...ches.com>
	Date:   Wed Aug 28 10:16:00 2013 +1000
	checkpatch: warn when using extern with function prototypes in .h files

	Using the extern keyword on function prototypes is superfluous visual
	noise so suggest removing it.

This is inaccurate.  It's actually a useful visual cue - so if anything, please
make checkpatch indicate that it be added to all future function prototypes.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/