linux-kernel - Re: [PATCH 3/4] mm/hwpoison: fix false report 2nd try page recovery

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1378146866-4o68qbq7-mutt-n-horiguchi@ah.jp.nec.com>
Date:	Mon, 02 Sep 2013 14:34:26 -0400
From:	Naoya Horiguchi <n-horiguchi@...jp.nec.com>
To:	Wanpeng Li <liwanp@...ux.vnet.ibm.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Andi Kleen <andi@...stfloor.org>,
	Fengguang Wu <fengguang.wu@...el.com>,
	Tony Luck <tony.luck@...el.com>, gong.chen@...ux.intel.com,
	linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/4] mm/hwpoison: fix false report 2nd try page recovery

On Mon, Sep 02, 2013 at 08:33:43PM +0800, Wanpeng Li wrote:
> If the page is poisoned by software inject w/ MF_COUNT_INCREASED flag, there
> is a false report 2nd try page recovery which is not truth, this patch fix it
> by report first try free buddy page recovery if MF_COUNT_INCREASED is set.
> 
> Before patch:
> 
> [  346.332041] Injecting memory failure at pfn 200010
> [  346.332189] MCE 0x200010: free buddy, 2nd try page recovery: Delayed
> 
> After patch:
> 
> [  297.742600] Injecting memory failure at pfn 200010
> [  297.742941] MCE 0x200010: free buddy page recovery: Delayed
> 
> Signed-off-by: Wanpeng Li <liwanp@...ux.vnet.ibm.com>

Reviewed-by: Naoya Horiguchi <n-horiguchi@...jp.nec.com>

> ---
>  mm/memory-failure.c |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/mm/memory-failure.c b/mm/memory-failure.c
> index b114570..6293164 100644
> --- a/mm/memory-failure.c
> +++ b/mm/memory-failure.c
> @@ -1114,8 +1114,10 @@ int memory_failure(unsigned long pfn, int trapno, int flags)
>  			 * shake_page could have turned it free.
>  			 */
>  			if (is_free_buddy_page(p)) {
> -				action_result(pfn, "free buddy, 2nd try",
> -						DELAYED);
> +				if (flags & MF_COUNT_INCREASED)
> +					action_result(pfn, "free buddy", DELAYED);
> +				else
> +					action_result(pfn, "free buddy, 2nd try", DELAYED);
>  				return 0;
>  			}
>  			action_result(pfn, "non LRU", IGNORED);
> -- 
> 1.7.5.4
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/