linux-kernel - latest perf code fails to parse existing data file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <5225051C.3030608@gmail.com>
Date:	Mon, 02 Sep 2013 15:37:32 -0600
From:	David Ahern <dsahern@...il.com>
To:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	Adrian Hunter <adrian.hunter@...el.com>
CC:	LKML <linux-kernel@...r.kernel.org>
Subject: latest perf code fails to parse existing data file

Arnaldo/Adrian:

Latest acme core tree fails to parse an existing data file:

$ perf trace -i perf.data
0x16b8 [0x40]: failed to process type: 1
Failed to process events, error -22

git bisect traced it to:
$ git bisect bad
75562573bab35b129cfd342fc2bcf89da84a6644 is the first bad commit
commit 75562573bab35b129cfd342fc2bcf89da84a6644
Author: Adrian Hunter <adrian.hunter@...el.com>
Date:   Tue Aug 27 11:23:09 2013 +0300

     perf tools: Add support for PERF_SAMPLE_IDENTIFIER

     Enable parsing of samples with sample format bit 
PERF_SAMPLE_IDENTIFIER.
     In addition, if the kernel supports it, prefer it to selecting
     PERF_SAMPLE_ID thereby allowing non-matching sample types.

     Signed-off-by: Adrian Hunter <adrian.hunter@...el.com>
     Cc: David Ahern <dsahern@...il.com>
     Cc: Frederic Weisbecker <fweisbec@...il.com>
     Cc: Ingo Molnar <mingo@...nel.org>
     Cc: Jiri Olsa <jolsa@...hat.com>
     Cc: Mike Galbraith <efault@....de>
     Cc: Namhyung Kim <namhyung@...il.com>
     Cc: Paul Mackerras <paulus@...ba.org>
     Cc: Peter Zijlstra <peterz@...radead.org>
     Cc: Stephane Eranian <eranian@...gle.com>
     Link: 
http://lkml.kernel.org/r/1377591794-30553-8-git-send-email-adrian.hunter@intel.com
     Signed-off-by: Arnaldo Carvalho de Melo <acme@...hat.com>

:040000 040000 7df758341904d77c391b90ab6b6bac97324d144a 
93839bad8ab2e6d88d3037f3dc8fd721be5e8870 M	tools


If I revert the patch (and handle the missing __perf_evsel__sample_size 
in the tests code to get it to compile) it works -- file is parsed 
correctly.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/