linux-kernel - Re: [PATCH 1/3] perf core: Fix a mmap and munmap mismatched bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87zjruth1y.fsf@sejong.aot.lge.com>
Date:	Tue, 03 Sep 2013 18:01:29 +0900
From:	Namhyung Kim <namhyung@...nel.org>
To:	Chenggang Qin <chenggang.qin@...il.com>
Cc:	linux-kernel@...r.kernel.org, root <root@...e097011.sqa.cm4>,
	David Ahern <dsahern@...il.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Paul Mackerras <paulus@...ba.org>,
	Ingo Molnar <mingo@...hat.com>,
	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	Arjan van de Ven <arjan@...ux.intel.com>,
	Yanmin Zhang <yanmin.zhang@...el.com>,
	Wu Fengguang <fengguang.wu@...el.com>,
	Mike Galbraith <efault@....de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Chenggang Qin <chenggang.qcg@...bao.com>
Subject: Re: [PATCH 1/3] perf core: Fix a mmap and munmap mismatched bug

Hi Chenggang,

On Sun,  1 Sep 2013 23:29:43 +0800, Chenggang Qin wrote:
> From: root <root@...e097011.sqa.cm4>
>
> In function filename__read_debuglink(), while the ELF file is opend and mmapped
> in elf_begin(), but if this file is considered to not be usable during the
> following code, we will goto the close(fd) directly. The elf_end() is skipped.
> So, the mmaped ELF file cannot be munmapped. The memory areas are mmapped is
> exist during the life of perf. This is a memory leak.
> This patch fixed this bug.
> Thanks.

Reviewed-by: Namhyung Kim <namhyung@...nel.org>

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/