lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 03 Sep 2013 17:06:13 +0800 From: Chen Gang <gang.chen@...anux.com> To: Li Zefan <lizefan@...wei.com> CC: Joe Perches <joe@...ches.com>, 'Jiri Kosina' <trivial@...nel.org>, Jens Axboe <axboe@...nel.dk>, Guenter Roeck <linux@...ck-us.net>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH trivial] block/ioctl.c: let code match 'kernel code style' On 09/03/2013 04:55 PM, Li Zefan wrote: > Please don't. Pure colding style cleanup is discouraged. > Pardon? Do you mean "coding style", not "colding style"? (or it is my misunderstanding?). > You're not going to run checkpatch.pl on the whole kernel tree and fix > all the complaints, are you? > I am not going to, it seems that may be the 'job' of Joe and trivial@...nel.org? BTW: it seems you did not redirect my mails to "/dev/null". ;-) Thanks. > On 2013/9/3 16:29, Chen Gang wrote: >> For 'switch case', remove redundancy '\t' (also can let related lines >> within 80 columns) and remove redundancy empty lines, just like other >> 'switch case' which match 'kernel code style' within the file. >> >> Let blkpg_ioctl() within 80 columns. Let 2nd line of blkdev_ioctl() and >> __blkdev_driver_ioctl() align 1st line parameter's start position, just >> like blk_ioctl_discard() and blk_ioctl_zeroout() within the file. >> >> For is_unrecognized_ioctl(), can shrink the 'return' statement into one >> line (so can save 2 lines), it still matches 'kernel code style' and it >> is no conflict with others within the file. >> >> >> Signed-off-by: Chen Gang <gang.chen@...anux.com> >> --- >> block/ioctl.c | 216 ++++++++++++++++++++++++++++----------------------------- >> 1 files changed, 105 insertions(+), 111 deletions(-) > > > -- Chen Gang -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists