linux-kernel - Re: [gcv v3 08/35] tracing: Replace __get_cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <00000140e43e9da0-5a024162-7eb8-4642-a801-30b8a8153138-000000@email.amazonses.com>
Date:	Tue, 3 Sep 2013 14:34:04 +0000
From:	Christoph Lameter <cl@...ux.com>
To:	Steven Rostedt <rostedt@...dmis.org>
cc:	Tejun Heo <tj@...nel.org>, akpm@...uxfoundation.org,
	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...hat.com>, linux-arch@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [gcv v3 08/35] tracing: Replace __get_cpu_var uses

On Thu, 29 Aug 2013, Steven Rostedt wrote:

> On Wed, 28 Aug 2013 19:48:16 +0000
>
> > Index: linux/kernel/trace/trace.c
> > ===================================================================
> > --- linux.orig/kernel/trace/trace.c	2013-08-26 14:25:53.000000000 -0500
> > +++ linux/kernel/trace/trace.c	2013-08-26 14:26:29.464993617 -0500
> > @@ -1676,7 +1676,7 @@ static void __ftrace_trace_stack(struct
> >  	 */
> >  	barrier();
> >  	if (use_stack == 1) {
> > -		trace.entries		= &__get_cpu_var(ftrace_stack).calls[0];
> > +		trace.entries		= this_cpu_ptr(ftrace_stack.calls);
> >  		trace.max_entries	= FTRACE_STACK_MAX_ENTRIES;
> >
> >  		if (regs)
>
>
> This patch fails to build:
>
> kernel/trace/trace.c: In function ‘__ftrace_trace_stack’:
> kernel/trace/trace.c:1679:20: error: cast specifies array type

That is because you did not apply the first patch of this series that
fixes a bug in the macros.