linux-kernel - Re: [RFC][PATCH 03/18 v2] ftrace: Set ftrace internal function tracing RCU safe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 3 Sep 2013 06:54:22 -0700
From:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Jiri Olsa <jolsa@...hat.com>
Subject: Re: [RFC][PATCH 03/18 v2] ftrace: Set ftrace internal function
 tracing RCU safe

On Tue, Sep 03, 2013 at 09:22:24AM -0400, Steven Rostedt wrote:
> On Sat, 31 Aug 2013 12:44:31 -0700
> "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com> wrote:
> 
> > On Sat, Aug 31, 2013 at 01:11:20AM -0400, Steven Rostedt wrote:
> > > From: "Steven Rostedt (Red Hat)" <rostedt@...dmis.org>
> > > 
> > > Since none of the internal ftrace function tracing uses RCU in
> > > their callbacks, it is OK to set the global_ops (the one that
> > > they all use) to RCU safe.
> > > 
> > > Cc: Jiri Olsa <jolsa@...hat.com>
> > > Cc: Paul E. McKenney <paulmck@...ux.vnet.ibm.com>
> > > Signed-off-by: Steven Rostedt <rostedt@...dmis.org>
> > 
> > Acked-by: Paul E. McKenney <paulmck@...ux.vnet.ibm.com>
> 
> You must have liked this patch so much... that you acked it twice ;-)

Better safe than sorry?  No, that doesn't sound quite right...

							Thanx, Paul

> -- Steve
> 
> > 
> > > ---
> > >  kernel/trace/ftrace.c |    4 +++-
> > >  1 file changed, 3 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
> > > index d61f431..a45deaa 100644
> > > --- a/kernel/trace/ftrace.c
> > > +++ b/kernel/trace/ftrace.c
> > > @@ -1146,7 +1146,9 @@ static struct ftrace_ops global_ops = {
> > >  	.func			= ftrace_stub,
> > >  	.notrace_hash		= EMPTY_HASH,
> > >  	.filter_hash		= EMPTY_HASH,
> > > -	.flags			= FTRACE_OPS_FL_RECURSION_SAFE | FTRACE_OPS_FL_INITIALIZED,
> > > +	.flags			= FTRACE_OPS_FL_RECURSION_SAFE |
> > > +				  FTRACE_OPS_FL_INITIALIZED |
> > > +				  FTRACE_OPS_FL_RCU_SAFE,
> > >  	INIT_REGEX_LOCK(global_ops)
> > >  };
> > > 
> > > -- 
> > > 1.7.10.4
> > > 
> > > 
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/