linux-kernel - input: i8042 possible bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 03 Sep 2013 21:39:10 +0400
From:	Andrey Moiseev <o2g.org.ru@...il.com>
To:	linux-input@...r.kernel.org
CC:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	linux-kernel@...r.kernel.org
Subject: input: i8042 possible bug

Here is an extract from drivers/input/serio/i8042.c:
> 
> static int i8042_flush(void)
> {
> 	unsigned long flags;
> 	unsigned char data, str;
> 	int i = 0;
> 
> 	spin_lock_irqsave(&i8042_lock, flags);
> 
> 	while (((str = i8042_read_status()) & I8042_STR_OBF) && (i < I8042_BUFFER_SIZE)) {
> 		udelay(50);
> 		data = i8042_read_data();
> 		i++;
> 		dbg("%02x <- i8042 (flush, %s)\n",
> 		    data, str & I8042_STR_AUXDATA ? "aux" : "kbd");
> 	}
> 
> 	spin_unlock_irqrestore(&i8042_lock, flags);
> 
> 	return i;
> }
> 
> static int i8042_controller_check(void)
> {
> 	if (i8042_flush() == I8042_BUFFER_SIZE) {
Doesn't it panic needlessly, while the buffer was initially full?
> 		pr_err("No controller found\n");
> 		return -ENODEV;
> 	}
> 
> 	return 0;
> }


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/