linux-kernel - Re: [PATCH] drm/i915: i915.disable_pch_pwm overrides PCH_PWM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKMK7uHUr-qw491-kPjX=qHE+wtcYHC-bMyGehHDuF7w0Jkp7w@mail.gmail.com>
Date:	Tue, 3 Sep 2013 19:50:00 +0200
From:	Daniel Vetter <daniel.vetter@...ll.ch>
To:	Kamal Mostafa <kamal@...onical.com>
Cc:	David Airlie <airlied@...ux.ie>,
	intel-gfx <intel-gfx@...ts.freedesktop.org>,
	dri-devel <dri-devel@...ts.freedesktop.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/i915: i915.disable_pch_pwm overrides PCH_PWM_ENABLE quirk

On Tue, Sep 3, 2013 at 7:37 PM, Kamal Mostafa <kamal@...onical.com> wrote:
> BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=47941
>
> Some BIOS configurations of Dell XPS13 are adversely affected by e85843b
> ("drm/i915: quirk no PCH_PWM_ENABLE for Dell XPS13 backlight") so provide a
> boot param to inhibit the quirk, or force it on.
>
> i915.disable_pch_pwm can be set to
>  -1: auto (default; allows the disabling of pch_pwm by dmi quirk table match)
>   0: inhibits the disabling of pch_pwm (overrides dmi quirk table match)
>   1: forces the disabling of pch_pwm
>
> Signed-off-by: Kamal Mostafa <kamal@...onical.com>

Nack. Piling quirk over quirk isn't the right approach and I think I
should just revert the pch_pwm enable quirk again.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/