linux-kernel - Re: usb: host: Faraday fotg210-hcd driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130903213205.GA7433@redhat.com>
Date:	Tue, 3 Sep 2013 17:32:05 -0400
From:	Dave Jones <davej@...hat.com>
To:	Greg KH <gregkh@...uxfoundation.org>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	john453@...aday-tech.com
Subject: Re: usb: host: Faraday fotg210-hcd driver

On Tue, Sep 03, 2013 at 02:23:55PM -0700, Greg KH wrote:

 > >  > +config USB_FOTG210_HCD
 > >  > +	tristate "FOTG210 HCD support"
 > >  > +	depends on USB
 > >  > +	default N
 > >  > +	---help---
 > >  > +	  Faraday FOTG210 is an OTG controller which can be configured as
 > >  > +	  an USB2.0 host. It is designed to meet USB2.0 EHCI specification
 > >  > +	  with minor modification.
 > >  > +
 > >  > +	  To compile this driver as a module, choose M here: the
 > >  > +	  module will be called fotg210-hcd.
 > >  > +
 > > 
 > > Shouldn't this depend on USB_OTG ?
 > > Seems odd to have OTG related options presented to me when I have that unset.
 > 
 > It's a USB Host controller, so it should be built if you have that
 > option set.  The fact that it can do OTG isn't an issue here, from what
 > I can tell.

Ok. It still likely needs a 'depends on $ARCH (arm?) | COMPILE_TEST' though.

	Dave

PS: What happened with this driver ?

This patch landed twice in your tree, once in 1dd3d123239179fad5de5dc00a6e0014a1918fde from Yuan-Hsin Chen <yhchen@...aday-tech.com>
and then in 7d50195f6c5005d6ae7a789d9a7f0a94d104ee96 from Feng-Hsin Chiang <john453@...aday-tech.com>

Given the former address seems to be broken, perhaps all those mentions of it
in the faraday sources need updating ?

----- The following addresses had permanent fatal errors -----
<yhchen@...aday-tech.com>
    (reason: 553 5.1.3 <yhchen@...aday-tech.com>... Check FTC account failure!<2>)

   ----- Transcript of session follows -----
... while talking to mailhost1.faraday-tech.com.:
>>> DATA
<<< 553 5.1.3 <yhchen@...aday-tech.com>... Check FTC account failure!<2>
550 5.1.1 <yhchen@...aday-tech.com>... User unknown
<<< 503 5.0.0 Need RCPT (recipient)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/