linux-kernel - Re: [PATCH v3 1/2] ARM: OMAP: Add secure function omap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <201309041010.30090@pali>
Date:	Wed, 4 Sep 2013 10:10:29 +0200
From:	Pali Rohár <pali.rohar@...il.com>
To:	Ивайло Димитров 
	<freemangordon@....bg>, Dave Martin <Dave.Martin@....com>,
	tony@...mide.com, nm@...com
Cc:	linux@....linux.org.uk, aaro.koskinen@....fi,
	pdeschrijver@...dia.com, linux-kernel@...r.kernel.org,
	santosh.shilimkar@...com, pavel@....cz, linux-omap@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v3 1/2] ARM: OMAP: Add secure function omap_smc3() which calling instruction smc #1

On Sunday 11 August 2013 20:36:40 Ивайло Димитров wrote:
>   >-------- Оригинално писмо --------
>  >
>  >От:  Dave Martin
>  >Относно: Re: [PATCH v3 1/2] ARM: OMAP: Add secure function
>  >omap_smc3() which
> 
>  calling instruction smc #1
> 
>  >До: Pali Rohár
>  >Изпратено на: Понеделник, 2013, Август 5 16:29:44 EEST
>  >
>  >On Sun, Aug 04, 2013 at 10:45:00AM +0200, Pali Rohár wrote:
>  >> Here is new version (v3) of omap secure part patch:
>  >> 
>  >> Other secure functions omap_smc1() and omap_smc2() calling
>  >> instruction smc #0 but Nokia RX-51 board needs to call
>  >> smc #1 for PPA access.
>  >> 
>  >> Signed-off-by: Ivaylo Dimitrov
>  >> Signed-off-by: Pali Rohár
>  >> ---
>  >> diff --git a/arch/arm/mach-omap2/omap-secure.h
>  >> b/arch/arm/mach-omap2/omap-secure.h index
>  >> 0e72917..c4586f4 100644
>  >> --- a/arch/arm/mach-omap2/omap-secure.h
>  >> +++ b/arch/arm/mach-omap2/omap-secure.h
>  >> @@ -51,6 +51,7 @@
>  >> 
>  >>  extern u32 omap_secure_dispatcher(u32 idx, u32 flag, u32
>  >>  nargs,
>  >>  
>  >>  				u32 arg1, u32 arg2, u32 arg3, u32 arg4);
>  >>  
>  >>  extern u32 omap_smc2(u32 id, u32 falg, u32 pargs);
>  >> 
>  >> +extern u32 omap_smc3(u32 id, u32 process, u32 flag, u32
>  >> pargs);
>  >> 
>  >>  extern phys_addr_t omap_secure_ram_mempool_base(void);
>  >>  extern int omap_secure_ram_reserve_memblock(void);
>  >> 
>  >> diff --git a/arch/arm/mach-omap2/omap-smc.S
>  >> b/arch/arm/mach-omap2/omap-smc.S index f6441c1..7bbc043
>  >> 100644
>  >> --- a/arch/arm/mach-omap2/omap-smc.S
>  >> +++ b/arch/arm/mach-omap2/omap-smc.S
>  >> @@ -1,9 +1,11 @@
>  >> 
>  >>  /*
>  >> 
>  >> - * OMAP44xx secure APIs file.
>  >> + * OMAP34xx and OMAP44xx secure APIs file.
>  >> 
>  >>   *
>  >>   * Copyright (C) 2010 Texas Instruments, Inc.
>  >>   * Written by Santosh Shilimkar
>  >>   *
>  >> 
>  >> + * Copyright (C) 2012 Ivaylo Dimitrov
>  >> + * Copyright (C) 2013 Pali Rohár
>  >> 
>  >>   *
>  >>   * This program is free software,you can redistribute it
>  >>   and/or modify * it under the terms of the GNU General
>  >>   Public License version 2 as
>  >> 
>  >> @@ -54,6 +56,23 @@ ENTRY(omap_smc2)
>  >> 
>  >>  	ldmfd   sp!, {r4-r12, pc}
>  >>  
>  >>  ENDPROC(omap_smc2)
>  >> 
>  >> +/**
>  >> + * u32 omap_smc3(u32 service_id, u32 process_id, u32
>  >> flag, u32 pargs) + * Low level common routine for secure
>  >> HAL and PPA APIs via smc #1 + * r0 - @service_id: Secure
>  >> Service ID
>  >> + * r1 - @process_id: Process ID
>  >> + * r2 - @flag: Flag to indicate the criticality of
>  >> operation + * r3 - @pargs: Physical address of parameter
>  >> list + */
>  >> +ENTRY(omap_smc3)
>  >> +	stmfd	sp!, {r4-r11, lr}
>  >> +	mov	r12, r0		@ Copy the secure service ID
>  >> +	mov	r6, #0xff	@ Indicate new Task call
>  >> +	dsb			@ Memory Barrier
>  >
>  >Can you explain _why_ the barrier is there?  The reader
>  >doesn't need to be told that a barrier instruction is a
>  >barrier instruction.
>  >
>  >Cheers
>  >---Dave
> 
> Hi Dave,
> 
> Would quoting Santosh's explanation "DSBs were needed on OMAP
> for power sequencing." do the job? Something like "@ Needed
> on OMAP for power sequencing" instead of "@ Memory Barrier".
> 
> I want to be sure I correctly understand your requirement.
> 
> Regards,
> Ivo

Hello,

I'd like to know what happened with this patch? What is needed 
for including it into mainline? Note that without with this patch 
series Thumb-2 user space binaries crashing.

-- 
Pali Rohár
pali.rohar@...il.com

Download attachment "signature.asc " of type "application/pgp-signature" (199 bytes)