linux-kernel - Re: [PATCH] clocksource: em_sti: Set cpu_possible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130904083727.GE17329@verge.net.au>
Date:	Wed, 4 Sep 2013 17:37:29 +0900
From:	Simon Horman <horms@...ge.net.au>
To:	Magnus Damm <magnus.damm@...il.com>
Cc:	linux-kernel@...r.kernel.org,
	Daniel Lezcano <daniel.lezcano@...aro.org>,
	linux@....linux.org.uk, arnd@...db.de, linux-sh@...r.kernel.org,
	sboyd@...eaurora.org, rob.herring@...xeda.com, olof@...om.net,
	santosh.shilimkar@...com, grant.likely@...aro.org,
	tglx@...utronix.de
Subject: Re: [PATCH] clocksource: em_sti: Set cpu_possible_mask to fix SMP
 broadcast

[ Droped johnstultz@...aro.org CC, the address seems to bounce
  Added Daniel Lezcano CC, I believe he handles clocksource these days ]

On Wed, Sep 04, 2013 at 05:01:51PM +0900, Magnus Damm wrote:
> From: Magnus Damm <damm@...nsource.se>
> 
> Update the STI driver by setting cpu_possible_mask to make EMEV2
> SMP work as expected together with the ARM broadcast timer.
> 
> This breakage was introduced by:
> 
> f7db706 ARM: 7674/1: smp: Avoid dummy clockevent being preferred over real hardware clock-event
> 
> Without this fix SMP operation is broken on EMEV2 since no
> broadcast timer interrupts trigger on the secondary CPU cores.
> 
> Signed-off-by: Magnus Damm <damm@...nsource.se>

Tested-by: Simon Horman <horms+renesas@...ge.net.au>

I will let this sit for a few days to see if there is any further feedback.

> ---
> 
>  Thanks to feedback from Stephen Boyd this is is a reworked version of:
>  [PATCH] clocksource: em_sti: Adjust clock event rating to fix SMP broadcast
> 
>  drivers/clocksource/em_sti.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- 0001/drivers/clocksource/em_sti.c
> +++ work/drivers/clocksource/em_sti.c	2013-09-04 16:51:42.000000000 +0900
> @@ -301,7 +301,7 @@ static void em_sti_register_clockevent(s
>  	ced->name = dev_name(&p->pdev->dev);
>  	ced->features = CLOCK_EVT_FEAT_ONESHOT;
>  	ced->rating = 200;
> -	ced->cpumask = cpumask_of(0);
> +	ced->cpumask = cpu_possible_mask;
>  	ced->set_next_event = em_sti_clock_event_next;
>  	ced->set_mode = em_sti_clock_event_mode;
>  
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/