linux-kernel - Re: [PATCH 1/4] ab8500-charger: Check return value of regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK9yfHwDRP+WV_RWGhuw=8uZEBKVFqLQucVdhQnP20s9YvBsRw@mail.gmail.com>
Date:	Wed, 4 Sep 2013 15:28:25 +0530
From:	Sachin Kamat <sachin.kamat@...aro.org>
To:	Lee Jones <lee.jones@...aro.org>
Cc:	LKML <linux-kernel@...r.kernel.org>, anton@...msg.org
Subject: Re: [PATCH 1/4] ab8500-charger: Check return value of regulator_enable

On 4 September 2013 15:11, Lee Jones <lee.jones@...aro.org> wrote:
> On Mon, 02 Sep 2013, Sachin Kamat wrote:
>
>> Check the return value of regulator_enable to silence the following
>> type of warnings:
>> drivers/power/ab8500_charger.c:1390:20: warning: ignoring return value
>> of ‘regulator_enable’, declared with attribute warn_unused_result
>> [-Wunused-result]
>
> I think I remember something about it being okay for the regulators to
> fail, but that may have been something else. I think I'd be more
> comfortable if we just raised a dev_warn() and didn't return early in
> the error case.

In this particular case the regulator seems to be mandatory as they error out if
regulator_get() fails. Also, the comment above regulator_enable() said
the enabling
was done to fix some bug. Hence I wasn't sure if we could just print a
warning message
and continue further upon failure. I will change it as per your
suggestion and re-spin the patches.

-- 
With warm regards,
Sachin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/