[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20130904135143.GJ20150@lee--X1>
Date: Wed, 4 Sep 2013 14:51:43 +0100
From: Lee Jones <lee.jones@...aro.org>
To: Mark Rutland <mark.rutland@....com>
Cc: "linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"jic23@....ac.uk" <jic23@....ac.uk>,
"linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
"linus.walleij@...aro.org" <linus.walleij@...aro.org>,
"denis.ciocca@...com" <denis.ciocca@...com>,
"arnd@...db.de" <arnd@...db.de>
Subject: Re: [PATCH 02/11] ARM: ux500: Enable the LPS001WP Pressure &
Temperature sensor from DT
On Wed, 04 Sep 2013, Mark Rutland wrote:
> Hi Lee,
>
> On Wed, Sep 04, 2013 at 10:31:34AM +0100, Lee Jones wrote:
> > After applying this node the LPS001WP sensor chip should probe
> > successfully once the driver support has also been applied.
> >
> > Signed-off-by: Lee Jones <lee.jones@...aro.org>
> > ---
> > arch/arm/boot/dts/ste-snowball.dts | 10 ++++++++++
> > 1 file changed, 10 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/ste-snowball.dts b/arch/arm/boot/dts/ste-snowball.dts
> > index cf9b16e..aad8f54 100644
> > --- a/arch/arm/boot/dts/ste-snowball.dts
> > +++ b/arch/arm/boot/dts/ste-snowball.dts
> > @@ -153,6 +153,16 @@
> > status = "okay";
> > };
> >
> > + i2c@...28000 {
> > + lps001wp@5c {
> > + compatible = "lps001wp";
> > + reg = <0x5c>;
> > +
> > + vdd-supply = <&ab8500_ldo_aux1_reg>;
> > + vms-supply = <&db8500_vsmps2_reg>;
> > + };
> > + };
> > +
>
> This appears to be missing a binding document. I couldn't see one
> anywhere in this series, or in mainline already).
>
> As far as I can see, the compatible string should be "st,lps001wp".
>
> Please produce a binding document.
Patch sent, most of you are on CC.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists