linux-kernel - Re: [tip:timers/urgent] sched/cputime: Do not scale when utime == 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130904153507.GC2308@somewhere>
Date:	Wed, 4 Sep 2013 17:35:08 +0200
From:	Frederic Weisbecker <fweisbec@...il.com>
To:	mingo@...nel.org, hpa@...or.com, linux-kernel@...r.kernel.org,
	peterz@...radead.org, sergey.senozhatsky@...il.com, bp@...en8.de,
	paulmck@...ux.vnet.ibm.com, tglx@...utronix.de, sgruszka@...hat.com
Cc:	linux-tip-commits@...r.kernel.org
Subject: Re: [tip:timers/urgent] sched/cputime: Do not scale when utime == 0

On Wed, Sep 04, 2013 at 07:37:22AM -0700, tip-bot for Stanislaw Gruszka wrote:
> Commit-ID:  5a8e01f8fa51f5cbce8f37acc050eb2319d12956
> Gitweb:     http://git.kernel.org/tip/5a8e01f8fa51f5cbce8f37acc050eb2319d12956
> Author:     Stanislaw Gruszka <sgruszka@...hat.com>
> AuthorDate: Wed, 4 Sep 2013 15:16:03 +0200
> Committer:  Ingo Molnar <mingo@...nel.org>
> CommitDate: Wed, 4 Sep 2013 16:31:25 +0200
> 
> sched/cputime: Do not scale when utime == 0
> 
> scale_stime() silently assumes that stime < rtime, otherwise
> when stime == rtime and both values are big enough (operations
> on them do not fit in 32 bits), the resulting scaling stime can
> be bigger than rtime. In consequence utime = rtime - stime
> results in negative value.
> 
> User space visible symptoms of the bug are overflowed TIME
> values on ps/top, for example:
> 
>  $ ps aux | grep rcu
>  root         8  0.0  0.0      0     0 ?        S    12:42   0:00 [rcuc/0]
>  root         9  0.0  0.0      0     0 ?        S    12:42   0:00 [rcub/0]
>  root        10 62422329  0.0  0     0 ?        R    12:42 21114581:37 [rcu_preempt]
>  root        11  0.1  0.0      0     0 ?        S    12:42   0:02 [rcuop/0]
>  root        12 62422329  0.0  0     0 ?        S    12:42 21114581:35 [rcuop/1]
>  root        10 62422329  0.0  0     0 ?        R    12:42 21114581:37 [rcu_preempt]
> 
> or overflowed utime values read directly from /proc/$PID/stat
> 
> Reference:
> 
>   https://lkml.org/lkml/2013/8/20/259
> 
> Reported-and-tested-by: Sergey Senozhatsky <sergey.senozhatsky@...il.com>
> Signed-off-by: Stanislaw Gruszka <sgruszka@...hat.com>
> Cc: stable@...r.kernel.org
> Cc: Frederic Weisbecker <fweisbec@...il.com>
> Cc: Peter Zijlstra <peterz@...radead.org>
> Cc: Paul E. McKenney <paulmck@...ux.vnet.ibm.com>
> Cc: Borislav Petkov <bp@...en8.de>
> Link: http://lkml.kernel.org/r/20130904131602.GC2564@redhat.com
> Signed-off-by: Ingo Molnar <mingo@...nel.org>

Thanks a lot guys!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/