linux-kernel - Re: [GIT PULL] x86/asmlinkage changes for v3.12

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFxVv==DC0JdS87V+cPr-twN+TujYg5XmgHOjJOAkZ4xwQ@mail.gmail.com>
Date:	Wed, 4 Sep 2013 08:58:25 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Ingo Molnar <mingo@...nel.org>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	"H. Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Jeremy Fitzhardinge <jeremy@...p.org>
Subject: Re: [GIT PULL] x86/asmlinkage changes for v3.12

On Tue, Sep 3, 2013 at 7:39 AM, Ingo Molnar <mingo@...nel.org> wrote:
>
> Please pull the latest x86-asmlinkage-for-linus git tree from:

Grr. This one seems to introduce this annoying warning:

arch/x86/kernel/paravirt.c:66:0: warning: "DEF_NATIVE" redefined
[enabled by default]
 #define DEF_NATIVE(ops, name, code)     \
 ^
In file included from
/home/torvalds/v2.6/linux/arch/x86/include/asm/ptrace.h:65:0,
                 from
/home/torvalds/v2.6/linux/arch/x86/include/asm/alternative.h:8,
                 from
/home/torvalds/v2.6/linux/arch/x86/include/asm/bitops.h:16,
                 from include/linux/bitops.h:22,
                 from include/linux/kernel.h:10,
                 from include/linux/cache.h:4,
                 from include/linux/time.h:4,
                 from include/linux/stat.h:18,
                 from include/linux/module.h:10,
                 from arch/x86/kernel/paravirt.c:22:
/home/torvalds/v2.6/linux/arch/x86/include/asm/paravirt_types.h:389:0:
note: this is the location of the previous definition
 #define DEF_NATIVE(ops, name, code)      \
 ^

when doing an allmodconfig.

Maybe it gets fixed later in the series (I am about a third through
your pull requests), but it's clearly bogus.

What the heck is wrong with that macro anyway? It is used in one
single file, and it is _defined_ twice - in two other files. Somebody
was very very confused when they wrote that code.

I'm going to let the pull stand, since it doesn't seem to actually
break anything, but this needs to be fixed.

                Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/