linux-kernel - Re: [PATCH 2/5] new fscache interface to check cache consistency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <18832.1378311843@warthog.procyon.org.uk>
Date:	Wed, 04 Sep 2013 17:24:03 +0100
From:	David Howells <dhowells@...hat.com>
To:	Hongyi Jia <jiayisuse@...il.com>, milosz@...in.com
Cc:	dhowells@...hat.com, ceph-devel@...r.kernel.org, sage@...tank.com,
	zheng.z.yan@...el.com, linux-cachefs@...hat.com,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/5] new fscache interface to check cache consistency

Hongyi Jia <jiayisuse@...il.com> wrote:

> +bool __fscache_check_consistency(struct fscache_cookie *cookie)
> +{
> +	struct fscache_object *object;
> +
> +	if (cookie->def->type != FSCACHE_COOKIE_TYPE_DATAFILE)
> +		return false;
> +
> +	if (hlist_empty(&cookie->backing_objects))
> +		return false;
> +
> +	object = hlist_entry(cookie->backing_objects.first,
> +			struct fscache_object, cookie_link);
> +
> +	return object->cache->ops->check_consistency(object);
> +}

Hmmm...  This isn't actually safe.  You have to either:

 (1) hold cookie->lock whilst touching the object pointer when coming from the
     netfs side, or:

 (2) set up an operation to do this (as, say, __fscache_alloc_page() does).

The problem is that you have nothing to defend against the object being
withdrawn by the cache under you.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/