linux-kernel - Re: [PATCH 2/5] new fscache interface to check cache consistency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANP1eJEo_dNyYU+ZdvrwKfFPihig9m-Yf_-bUoXym-MF5bGnQg@mail.gmail.com>
Date:	Wed, 4 Sep 2013 14:04:24 -0400
From:	Milosz Tanski <milosz@...in.com>
To:	David Howells <dhowells@...hat.com>
Cc:	Hongyi Jia <jiayisuse@...il.com>,
	ceph-devel <ceph-devel@...r.kernel.org>,
	Sage Weil <sage@...tank.com>,
	"Yan, Zheng" <zheng.z.yan@...el.com>,
	"linux-cachefs@...hat.com" <linux-cachefs@...hat.com>,
	"linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/5] new fscache interface to check cache consistency

David,

Is it as simple as stick a mutex at the top of the
__fscache_check_consistency function before we try to find the object?
This code should be called from a context that can sleep, in the Ceph
code we call it from a delayed work queue (revalidate queue).

-- Milosz

On Wed, Sep 4, 2013 at 1:26 PM, David Howells <dhowells@...hat.com> wrote:
> Milosz Tanski <milosz@...in.com> wrote:
>
>> If the cache is withdrawn and we're starting anew I would consider
>> that to okay. I would consider an empty page cache for a cookie to be
>> consistent since there's nothing stale that I can read. Unless there's
>> another synchronization issue that I'm missing in fscache.
>
> The problem is that the fscache_object struct may be deallocated whilst you're
> using it.
>
> David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/