linux-kernel - Re: [alsa-devel] [PATCH] ASoC: codecs: da9055: Update driver name to fix breakage due to pmic driver with same name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20130904183405.GX3084@sirena.org.uk>
Date:	Wed, 4 Sep 2013 19:34:05 +0100
From:	Mark Brown <broonie@...nel.org>
To:	"Opensource [Adam Thomson]" <Adam.Thomson.Opensource@...semi.com>
Cc:	Ashish Chavan <ashish.chavan@...tcummins.com>, lrg <lrg@...com>,
	alsa-devel <alsa-devel@...a-project.org>,
	David Dajun Chen <david.chen@...semi.com>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	"kiran.padwal" <kiran.padwal@...tcummins.com>
Subject: Re: [alsa-devel] [PATCH] ASoC: codecs: da9055: Update driver name to
 fix breakage due to pmic driver with same name

On Wed, Sep 04, 2013 at 04:13:25PM +0000, Opensource [Adam Thomson] wrote:

> Personally I don't see the issue in having two I2C clients defined for the one
> chip, in the machine bindings. Logically it's absolutely correct for the chip,
> and as long as the I2C IDs for the devices make sense (which wasn't the case for
> DA9055, and is something I want to rectify), then it should be obvious
> to anyone who comes across that code. Actually having them as two separate
> entries in machine code helps to highlight that they are individual I2C devices
> in one package rather than somehow linked internally and requiring ordered
> initialisation. That seems right to me, and would tally with the associated
> datasheet for the device.

The goal is that users shouldn't even need to have to think about how
the chip is constructed, they should just be able to use it with minimal
thought or effort.  Anything that can be encapsulated within the drivers
should be.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)