linux-kernel - Re: [PATCH 2/5] new fscache interface to check cache consistency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 4 Sep 2013 18:02:57 -0400
From:	Milosz Tanski <milosz@...in.com>
To:	David Howells <dhowells@...hat.com>
Cc:	Hongyi Jia <jiayisuse@...il.com>,
	ceph-devel <ceph-devel@...r.kernel.org>,
	Sage Weil <sage@...tank.com>,
	"Yan, Zheng" <zheng.z.yan@...el.com>,
	"linux-cachefs@...hat.com" <linux-cachefs@...hat.com>,
	"linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/5] new fscache interface to check cache consistency

David,

Is there anyway I can call you at (at your desk) during EST hours. I'd
like to talk this part through since I think we're going a bit in
circles. I'd like to get this fixed so we can submit the fscache for
Ceph code for the upstream kernel in the merge window.

Best,
-- Milosz

On Wed, Sep 4, 2013 at 3:41 PM, Milosz Tanski <milosz@...in.com> wrote:
> On Wed, Sep 4, 2013 at 2:13 PM, David Howells <dhowells@...hat.com> wrote:
>> Milosz Tanski <milosz@...in.com> wrote:
>>
>>> Is it as simple as stick a mutex at the top of the
>>> __fscache_check_consistency function before we try to find the object?
>>
>> You can lock a mutex in a function, but where are you actually going to place
>> the mutex struct?  And what other code is going to take it?  To do this, you'd
>> have to place the mutex struct in fscache_cookie.  The problem is that you
>> have to protect the pointer from fscache_cookie to fscache_object - so placing
>> the mutex in fscache_object doesn't help.
>
> David,
>
> I meant lock cookie->lock inside of __fscache_check_consistency in the
> beginning of the function. I don't see the need to push this into the
> netfs code.
>
> - Milosz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/