linux-kernel - drivers/char/hpet.c check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CA+i0qc6GH2Otr7MkTyXLA+DLK37cDoGmkmu+ymVicq8g+fo9SQ@mail.gmail.com>
Date:	Wed, 4 Sep 2013 03:16:09 +0300
From:	Tomas Winkler <tomasw@...il.com>
To:	": Randy Dunlap" <rdunlap@...radead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: drivers/char/hpet.c check

In hpet_resources function

Can anybody explain why we check fixmem32 for NULL, looks strange as
it derreferences  a member address

I'm asking since a static analyzer is complaining about it.

       } else if (res->id == ACPI_RSTYPE_FIXED_MEM32) {
              struct acpi_resource_fixed_mem32 *fixmem32;

               fixmem32 = &res->data.fixed_memory32;
               if (!fixmem32)
               ^^^^^^
                       return -EINVAL;

Thanks
Tomas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/