linux-kernel - Re: dvb-usb/technisat-usb2: Fix cut-n-paste thinko

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 05 Sep 2013 09:28:13 +0200
From:	Patrick Boettcher <pboettcher@...nellabs.com>
To:	Dave Jones <davej@...hat.com>
Cc:	mchehab@...hat.com, Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: dvb-usb/technisat-usb2: Fix cut-n-paste thinko

Hi Dave,

On Wednesday 04 September 2013 19:59:17 Dave Jones wrote:
> This looks like it was cut and pasted from the code above which does
> similar checks on txlen, but someone forgot to change the variable.

This someone would be me.

> Signed-off-by: Dave Jones <davej@...oraproject.org>
> 
> diff --git a/drivers/media/usb/dvb-usb/technisat-usb2.c
> b/drivers/media/usb/dvb-usb/technisat-usb2.c index 40832a1..98d24ae
> 100644
> --- a/drivers/media/usb/dvb-usb/technisat-usb2.c
> +++ b/drivers/media/usb/dvb-usb/technisat-usb2.c
> @@ -102,7 +102,7 @@ static int technisat_usb2_i2c_access(struct usb_device
> *udev, if (rxlen > 62) {
>  		err("i2c RX buffer can't exceed 62 bytes (dev 0x%02x)",
>  				device_addr);
> -		txlen = 62;
> +		rxlen = 62;
>  	}
> 
>  	b[0] = I2C_SPEED_100KHZ_BIT;

Nice catch.

Mauro, feel free to add my signed-off-line, when integrating

Signed-off-by: Patrick Boettcher <pboettcher@...nellabs.com>



--
Patrick 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/