linux-kernel - Re: [PATCH 1/3] kconfig: do not special-case 'MODULES' symbol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5228510C.1020906@suse.cz>
Date:	Thu, 05 Sep 2013 11:38:20 +0200
From:	Michal Marek <mmarek@...e.cz>
To:	"Yann E. MORIN" <yann.morin.1998@...e.fr>
Cc:	linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org,
	Sam Ravnborg <sam@...nborg.org>
Subject: Re: [PATCH 1/3] kconfig: do not special-case 'MODULES' symbol

On 3.9.2013 23:04, Yann E. MORIN wrote:
> From: "Yann E. MORIN" <yann.morin.1998@...e.fr>
> 
> Currently, the 'MODULES' symbol is hard-coded to be the default symbol
> that enables/disables tristates, if no other symbol was declared with
> 'option modules'.
> 
> While this used to be needed for the Linux kernel, we now have an
> explicit 'option modules' attached to the 'MODULES' symbol (since
> cset 11097a036), so we no longer need to special-case it in the
> kconfig code.
> 
> Furthermore, kconfig is extensively used out of the Linux kernel, and
> other projects may have another meaning for a symbol named 'MODULES'.
> 
> This patch changes the way we enable/disable tristates: if a symbol was
> found with 'option modules' attached to it, then that symbol controls
> enabling tristates. Otherwise, tristates are disabled, even if a symbol
> named 'MODULES' exists.

Wasn't this change supposed to fix allmodconfig with KCONFIG_ALLCONFIG
(http://lkml.org/lkml/2013/8/8/573)? Or is there still more to do?
Because I'm still getting:

$ touch empty
$ make KCONFIG_ALLCONFIG=empty allmodconfig
  HOSTCC  scripts/basic/fixdep
  HOSTCC  scripts/kconfig/conf.o
  SHIPPED scripts/kconfig/zconf.tab.c
  SHIPPED scripts/kconfig/zconf.lex.c
  SHIPPED scripts/kconfig/zconf.hash.c
  HOSTCC  scripts/kconfig/zconf.tab.o
  HOSTLD  scripts/kconfig/conf
scripts/kconfig/conf --allmodconfig Kconfig
#
# configuration written to .config
#
$ grep MODULES .config
CONFIG_MODULES_USE_ELF_RELA=y
# CONFIG_MODULES is not set
$

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/